Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1633)

Unified Diff: public/platform/WebDatabaseObserver.h

Issue 669063002: Remove isSyncDatabase in WebDatabaseObserver [3/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Final clean-up Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebDatabaseObserver.h
diff --git a/public/platform/WebDatabaseObserver.h b/public/platform/WebDatabaseObserver.h
index 9c02f6b26e270e8ba4bdbef155160a8d92adbc93..a2a9262b1a3b266495b8bfcb2c4bfd60100bd07e 100644
--- a/public/platform/WebDatabaseObserver.h
+++ b/public/platform/WebDatabaseObserver.h
@@ -37,8 +37,6 @@ class WebString;
class WebDatabaseObserver {
public:
- // FIXME: |isSyncDatabse| arguments are alwyas |false|. We should remove them.
-
virtual void databaseOpened(
const WebString& databaseIdentifier,
const WebString& databaseName,
@@ -53,76 +51,27 @@ public:
virtual void reportOpenDatabaseResult(
const WebString& databaseIdentifier,
const WebString& databaseName,
- int errorSite, int webSqlErrorCode, int sqliteErrorCode)
- {
- reportOpenDatabaseResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
- }
- virtual void reportChangeVersionResult(
- const WebString& databaseIdentifier,
- const WebString& databaseName,
- int errorSite, int webSqlErrorCode, int sqliteErrorCode)
- {
- reportChangeVersionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
- }
- virtual void reportStartTransactionResult(
- const WebString& databaseIdentifier,
- const WebString& databaseName,
- int errorSite, int webSqlErrorCode, int sqliteErrorCode)
- {
- reportStartTransactionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
- }
- virtual void reportCommitTransactionResult(
- const WebString& databaseIdentifier,
- const WebString& databaseName,
- int errorSite, int webSqlErrorCode, int sqliteErrorCode)
- {
- reportCommitTransactionResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
- }
- virtual void reportExecuteStatementResult(
- const WebString& databaseIdentifier,
- const WebString& databaseName,
- int errorSite, int webSqlErrorCode, int sqliteErrorCode)
- {
- reportExecuteStatementResult(databaseIdentifier, databaseName, false, errorSite, webSqlErrorCode, sqliteErrorCode);
- }
- virtual void reportVacuumDatabaseResult(
- const WebString& databaseIdentifier,
- const WebString& databaseName,
- int sqliteErrorCode)
- {
- reportVacuumDatabaseResult(databaseIdentifier, databaseName, false, sqliteErrorCode);
- }
-
- // FIXME: Remove these functions once we no longer use isSyncDatabase in Chromium.
- virtual void reportOpenDatabaseResult(
- const WebString& databaseIdentifier,
- const WebString& databaseName,
- bool isSyncDatabase,
int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
virtual void reportChangeVersionResult(
const WebString& databaseIdentifier,
const WebString& databaseName,
- bool isSyncDatabase,
int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
virtual void reportStartTransactionResult(
const WebString& databaseIdentifier,
const WebString& databaseName,
- bool isSyncDatabase,
int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
virtual void reportCommitTransactionResult(
const WebString& databaseIdentifier,
const WebString& databaseName,
- bool isSyncDatabase,
int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
virtual void reportExecuteStatementResult(
const WebString& databaseIdentifier,
const WebString& databaseName,
- bool isSyncDatabase,
int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
virtual void reportVacuumDatabaseResult(
const WebString& databaseIdentifier,
const WebString& databaseName,
- bool isSyncDatabase, int sqliteErrorCode) { }
+ int sqliteErrorCode) { }
protected:
~WebDatabaseObserver() { }
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698