Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 666333002: Remove isSyncDatabase in WebDatabaseObserver [2/3] (Closed)

Created:
6 years, 2 months ago by rtakacs
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove isSyncDatabase in WebDatabaseObserver [2/3] Removed codes related to isSyncDatabase and switched to the new methods that were introduced in the previous patch. [1] https://codereview.chromium.org/660873004/ [2] THIS PATCH [3] https://codereview.chromium.org/669063002/ BUG=428254 Committed: https://crrev.com/9ce67b848a520bf733599ed13549a08aac9daf2f Cr-Commit-Position: refs/heads/master@{#302301}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -40 lines) Patch
M content/child/web_database_observer_impl.h View 1 chunk +0 lines, -6 lines 0 comments Download
M content/child/web_database_observer_impl.cc View 7 chunks +13 lines, -34 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
rtakacs
6 years, 2 months ago (2014-10-22 09:27:22 UTC) #2
jam
lgtm
6 years, 2 months ago (2014-10-22 22:44:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666333002/1
6 years, 1 month ago (2014-10-30 19:44:04 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/29936) mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/30099)
6 years, 1 month ago (2014-10-30 19:53:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/666333002/1
6 years, 1 month ago (2014-10-31 16:24:08 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 19:01:23 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 19:02:21 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ce67b848a520bf733599ed13549a08aac9daf2f
Cr-Commit-Position: refs/heads/master@{#302301}

Powered by Google App Engine
This is Rietveld 408576698