Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: public/platform/WebDatabaseObserver.h

Issue 669063002: Remove isSyncDatabase in WebDatabaseObserver [3/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Final clean-up Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 19 matching lines...) Expand all
30 30
31 #ifndef WebDatabaseObserver_h 31 #ifndef WebDatabaseObserver_h
32 #define WebDatabaseObserver_h 32 #define WebDatabaseObserver_h
33 33
34 namespace blink { 34 namespace blink {
35 35
36 class WebString; 36 class WebString;
37 37
38 class WebDatabaseObserver { 38 class WebDatabaseObserver {
39 public: 39 public:
40 // FIXME: |isSyncDatabse| arguments are alwyas |false|. We should remove the m.
41
42 virtual void databaseOpened( 40 virtual void databaseOpened(
43 const WebString& databaseIdentifier, 41 const WebString& databaseIdentifier,
44 const WebString& databaseName, 42 const WebString& databaseName,
45 const WebString& databaseDisplayName, 43 const WebString& databaseDisplayName,
46 unsigned long estimatedSize) = 0; 44 unsigned long estimatedSize) = 0;
47 virtual void databaseModified( 45 virtual void databaseModified(
48 const WebString& databaseIdentifier, 46 const WebString& databaseIdentifier,
49 const WebString& databaseName) = 0; 47 const WebString& databaseName) = 0;
50 virtual void databaseClosed( 48 virtual void databaseClosed(
51 const WebString& databaseIdentifier, 49 const WebString& databaseIdentifier,
52 const WebString& databaseName) = 0; 50 const WebString& databaseName) = 0;
53 virtual void reportOpenDatabaseResult( 51 virtual void reportOpenDatabaseResult(
54 const WebString& databaseIdentifier, 52 const WebString& databaseIdentifier,
55 const WebString& databaseName, 53 const WebString& databaseName,
56 int errorSite, int webSqlErrorCode, int sqliteErrorCode)
57 {
58 reportOpenDatabaseResult(databaseIdentifier, databaseName, false, errorS ite, webSqlErrorCode, sqliteErrorCode);
59 }
60 virtual void reportChangeVersionResult(
61 const WebString& databaseIdentifier,
62 const WebString& databaseName,
63 int errorSite, int webSqlErrorCode, int sqliteErrorCode)
64 {
65 reportChangeVersionResult(databaseIdentifier, databaseName, false, error Site, webSqlErrorCode, sqliteErrorCode);
66 }
67 virtual void reportStartTransactionResult(
68 const WebString& databaseIdentifier,
69 const WebString& databaseName,
70 int errorSite, int webSqlErrorCode, int sqliteErrorCode)
71 {
72 reportStartTransactionResult(databaseIdentifier, databaseName, false, er rorSite, webSqlErrorCode, sqliteErrorCode);
73 }
74 virtual void reportCommitTransactionResult(
75 const WebString& databaseIdentifier,
76 const WebString& databaseName,
77 int errorSite, int webSqlErrorCode, int sqliteErrorCode)
78 {
79 reportCommitTransactionResult(databaseIdentifier, databaseName, false, e rrorSite, webSqlErrorCode, sqliteErrorCode);
80 }
81 virtual void reportExecuteStatementResult(
82 const WebString& databaseIdentifier,
83 const WebString& databaseName,
84 int errorSite, int webSqlErrorCode, int sqliteErrorCode)
85 {
86 reportExecuteStatementResult(databaseIdentifier, databaseName, false, er rorSite, webSqlErrorCode, sqliteErrorCode);
87 }
88 virtual void reportVacuumDatabaseResult(
89 const WebString& databaseIdentifier,
90 const WebString& databaseName,
91 int sqliteErrorCode)
92 {
93 reportVacuumDatabaseResult(databaseIdentifier, databaseName, false, sqli teErrorCode);
94 }
95
96 // FIXME: Remove these functions once we no longer use isSyncDatabase in Chr omium.
97 virtual void reportOpenDatabaseResult(
98 const WebString& databaseIdentifier,
99 const WebString& databaseName,
100 bool isSyncDatabase,
101 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { } 54 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
102 virtual void reportChangeVersionResult( 55 virtual void reportChangeVersionResult(
103 const WebString& databaseIdentifier, 56 const WebString& databaseIdentifier,
104 const WebString& databaseName, 57 const WebString& databaseName,
105 bool isSyncDatabase,
106 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { } 58 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
107 virtual void reportStartTransactionResult( 59 virtual void reportStartTransactionResult(
108 const WebString& databaseIdentifier, 60 const WebString& databaseIdentifier,
109 const WebString& databaseName, 61 const WebString& databaseName,
110 bool isSyncDatabase,
111 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { } 62 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
112 virtual void reportCommitTransactionResult( 63 virtual void reportCommitTransactionResult(
113 const WebString& databaseIdentifier, 64 const WebString& databaseIdentifier,
114 const WebString& databaseName, 65 const WebString& databaseName,
115 bool isSyncDatabase,
116 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { } 66 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
117 virtual void reportExecuteStatementResult( 67 virtual void reportExecuteStatementResult(
118 const WebString& databaseIdentifier, 68 const WebString& databaseIdentifier,
119 const WebString& databaseName, 69 const WebString& databaseName,
120 bool isSyncDatabase,
121 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { } 70 int errorSite, int webSqlErrorCode, int sqliteErrorCode) { }
122 virtual void reportVacuumDatabaseResult( 71 virtual void reportVacuumDatabaseResult(
123 const WebString& databaseIdentifier, 72 const WebString& databaseIdentifier,
124 const WebString& databaseName, 73 const WebString& databaseName,
125 bool isSyncDatabase, int sqliteErrorCode) { } 74 int sqliteErrorCode) { }
126 75
127 protected: 76 protected:
128 ~WebDatabaseObserver() { } 77 ~WebDatabaseObserver() { }
129 }; 78 };
130 79
131 } // namespace blink 80 } // namespace blink
132 81
133 #endif // WebDatabaseObserver_h 82 #endif // WebDatabaseObserver_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698