chrome/chrome_common.gypi - Issue 666813002: GN: Fix Android component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_common.gypi

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank

Patch Set: Actually undo gyp change Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/chrome_common.gypi

diff --git a/chrome/chrome_common.gypi b/chrome/chrome_common.gypi

index ccc83cb1360e63aaa2663513045bce162d710f98..47f6c5058a016a0784d30408cdcdc039d3d4b19b 100644

--- a/chrome/chrome_common.gypi

+++ b/chrome/chrome_common.gypi

@@ -272,6 +272,7 @@

'targets': [

{

+ # GN: //chrome/common:common

jamesr 2014/10/22 00:28:18 //chrome/common means the same thing and is shorte

cjhopman 2014/10/23 00:15:48 For these pointers in GYP to the GN target, I've b

'target_name': 'common',

'type': 'static_library',

'variables': {