Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4925)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/BUILD.gn

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank
Patch Set: Actually undo gyp change Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/chrome_common.gypi ('K') | « chrome/chrome_common.gypi ('k') | chrome/renderer/BUILD.gn » ('j') | components/bookmarks.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/BUILD.gn
diff --git a/chrome/common/BUILD.gn b/chrome/common/BUILD.gn
index d295f52f8b49d18136024133e292d64cd0f7faba..e2bef12e1f63fbbe4d110a091aee9488e09bd438 100644
--- a/chrome/common/BUILD.gn
+++ b/chrome/common/BUILD.gn
@@ -90,6 +90,7 @@ static_library("common") {
"//components/password_manager/core/common",
"//components/signin/core/common",
"//components/translate/content/common",
+ "//extensions/common",
"//ipc",
"//third_party/re2",
"//third_party/widevine/cdm:version_h",
@@ -104,7 +105,6 @@ static_library("common") {
"//device/bluetooth", # TODO(thestig) Still needed? Not in gyp version.
"//device/usb",
"//chrome/common/extensions/api",
- "//extensions/common",
"//extensions/common/api",
]
}
« chrome/chrome_common.gypi ('K') | « chrome/chrome_common.gypi ('k') | chrome/renderer/BUILD.gn » ('j') | components/bookmarks.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698