chrome/browser/safe_browsing/safe_browsing_service.cc - Issue 666813002: GN: Fix Android component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/safe_browsing_service.cc

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank

Patch Set: Actually undo gyp change Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/safe_browsing_service.cc

diff --git a/chrome/browser/safe_browsing/safe_browsing_service.cc b/chrome/browser/safe_browsing/safe_browsing_service.cc

index a01305c46a0aef1277ecc3c05270b0abb1341e75..981a27cf949d19dd6d21a7a5ea971c825f906a8e 100644

--- a/chrome/browser/safe_browsing/safe_browsing_service.cc

+++ b/chrome/browser/safe_browsing/safe_browsing_service.cc

@@ -361,9 +361,13 @@ SafeBrowsingDatabaseManager* SafeBrowsingService::CreateDatabaseManager() {

}

void SafeBrowsingService::RegisterAllDelayedAnalysis() {

+#if defined(FULL_SAFE_BROWSING)

jamesr 2014/10/22 00:28:18 i don't really understand this - could you get a c

cjhopman 2014/10/23 00:15:48 Acknowledged.

safe_browsing::RegisterBinaryIntegrityAnalysis();

safe_browsing::RegisterBlacklistLoadAnalysis();

safe_browsing::RegisterVariationsSeedSignatureAnalysis();

+#else

+ NOTREACHED();

+#endif

}

void SafeBrowsingService::InitURLRequestContextOnIOThread(