components/bookmarks.gypi - Issue 666813002: GN: Fix Android component build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/bookmarks.gypi

Issue 666813002: GN: Fix Android component build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-clank

Patch Set: Actually undo gyp change Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/bookmarks.gypi

diff --git a/components/bookmarks.gypi b/components/bookmarks.gypi

index 6f6b770bdd61edb04430e70c31a130e4a94fb77a..eaa7cabb5d19e680d933ed7382869b889053fc0e 100644

--- a/components/bookmarks.gypi

+++ b/components/bookmarks.gypi

@@ -60,6 +60,7 @@

'conditions': [

['OS == "android"', {

+ # GN version: //components/bookmarks/common/android

jamesr 2014/10/22 00:28:18 "GN version" comments are normally on target defin

cjhopman 2014/10/23 00:15:48 Added clarification.

'dependencies': [

'bookmarks_jni_headers',