Standardize usage of virtual/override/final in chrome/browser/media

Standardize usage of virtual/override/final in chrome/browser/media

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=scherkus@chromium.org

Committed: https://crrev.com/d7e84a0594e5394dbcbed676754cb1698339bfa0
Cr-Commit-Position: refs/heads/master@{#300579}

[scherkus (not reviewing), 2014-10-21 21:53:59]

need some clarification on whether the tool is missing some cases, or whether
I'm simply misinterpreting the new rules

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (right):

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:37: virtual
~MediaStreamInfoBarTest() {}
why wasn't this changed?

WebRtcTestBase appears to have a virtual dtor, as does InProcessBrowserTest, as
does InProcessBrowserTest, as does testing::Test

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
File chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc (right):

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc:60: virtual void
TearDown() override {
ditto?

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
File chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc
(right):

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc:31:
WebRtcDisableEncryptionFlagBrowserTest() {}
ditto

[dcheng, 2014-10-21 22:00:18]

You're not misinterpreting the rules, it does seem strange. You don't happen to
know if there's a chrome target for just these files? Otherwise, trying to
regenerate the entire patch to debug this case will be rather painful, and I'd
prefer to defer it to followups (since we'll need followup runs on
Linux/CrOS/Android, etc anyway).

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
File chrome/browser/media/chrome_media_stream_infobar_browsertest.cc (right):

https://codereview.chromium.org/665323004/diff/1/chrome/browser/media/chrome_...
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc:37: virtual
~MediaStreamInfoBarTest() {}
On 2014/10/21 21:53:59, scherkus wrote:
> why wasn't this changed?
> 
> WebRtcTestBase appears to have a virtual dtor, as does InProcessBrowserTest,
as
> does InProcessBrowserTest, as does testing::Test

Beats me. I'll look into this separately.

[scherkus (not reviewing), 2014-10-21 22:03:57]

thanks -- I wasn't sure if you were going for 100% or if edge cases were still
expected

lgtm

[dcheng, 2014-10-21 22:04:52]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2014-10-21 22:08:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/665323004/1

[commit-bot: I haz the power, 2014-10-22 00:19:32]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-10-22 00:20:30]

Patchset 1 (id:??) landed as
https://crrev.com/d7e84a0594e5394dbcbed676754cb1698339bfa0
Cr-Commit-Position: refs/heads/master@{#300579}