chrome/browser/media/webrtc_logging_handler_host.h - Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/webrtc_logging_handler_host.h

Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc ('K') | « chrome/browser/media/webrtc_log_uploader.h ('k') | chrome/browser/media/webrtc_rtp_dump_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/webrtc_logging_handler_host.h

diff --git a/chrome/browser/media/webrtc_logging_handler_host.h b/chrome/browser/media/webrtc_logging_handler_host.h

index 9b8398d26338fed4393d7dde8e2eceb1053388d9..9bf5db25396fcfe0a2ebfe6e8bedc09c9518d463 100644

--- a/chrome/browser/media/webrtc_logging_handler_host.h

+++ b/chrome/browser/media/webrtc_logging_handler_host.h

@@ -120,12 +120,12 @@ class WebRtcLoggingHandlerHost : public content::BrowserMessageFilter {

friend class content::BrowserThread;

friend class base::DeleteHelper<WebRtcLoggingHandlerHost>;

- virtual ~WebRtcLoggingHandlerHost();

+ ~WebRtcLoggingHandlerHost() override;

// BrowserMessageFilter implementation.

- virtual void OnChannelClosing() override;

- virtual void OnDestruct() const override;

- virtual bool OnMessageReceived(const IPC::Message& message) override;

+ void OnChannelClosing() override;

+ void OnDestruct() const override;

+ bool OnMessageReceived(const IPC::Message& message) override;

// Handles log message requests from renderer process.

void OnAddLogMessages(const std::vector<WebRtcLoggingMessageData>& messages);