chrome/browser/media/chrome_webrtc_webcam_browsertest.cc - Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/chrome_webrtc_webcam_browsertest.cc

Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc ('K') | « chrome/browser/media/chrome_webrtc_video_quality_browsertest.cc ('k') | chrome/browser/media/desktop_media_list_ash.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/chrome_webrtc_webcam_browsertest.cc

diff --git a/chrome/browser/media/chrome_webrtc_webcam_browsertest.cc b/chrome/browser/media/chrome_webrtc_webcam_browsertest.cc

index 70fa610e028e458b623d7da56c9cab26f5acc9df..6363531c63501a514c7b7a644ceeefd7e531ea83 100644

--- a/chrome/browser/media/chrome_webrtc_webcam_browsertest.cc

+++ b/chrome/browser/media/chrome_webrtc_webcam_browsertest.cc

@@ -39,7 +39,7 @@ static const char* kTestConfigFlags[] = {

class WebRtcWebcamBrowserTest : public WebRtcTestBase,

public testing::WithParamInterface<const char*> {

public:

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

EXPECT_FALSE(command_line->HasSwitch(

switches::kUseFakeDeviceForMediaStream));

EXPECT_FALSE(command_line->HasSwitch(

@@ -49,7 +49,7 @@ class WebRtcWebcamBrowserTest : public WebRtcTestBase,

}

protected:

- virtual void SetUpInProcessBrowserTestFixture() override {

+ void SetUpInProcessBrowserTestFixture() override {

DetectErrorsInJavaScript(); // Look for errors in our rather complex js.

}