chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc - Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc

Issue 665323004: Standardize usage of virtual/override/final in chrome/browser/media (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/media/chrome_webrtc_apprtc_browsertest.cc ('K') | « chrome/browser/media/chrome_webrtc_browsertest.cc ('k') | chrome/browser/media/chrome_webrtc_getmediadevices_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc

diff --git a/chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc b/chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc

index e6210f7eb36119390ba7c6cfaea0979708513aee..a3dfab9cf49393225607385816b68e4aa5e05346 100644

--- a/chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc

+++ b/chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc

@@ -31,11 +31,11 @@ class WebRtcDisableEncryptionFlagBrowserTest : public WebRtcTestBase {

WebRtcDisableEncryptionFlagBrowserTest() {}

scherkus (not reviewing) 2014/10/21 21:53:59 ditto

virtual ~WebRtcDisableEncryptionFlagBrowserTest() {}

- virtual void SetUpInProcessBrowserTestFixture() override {

+ void SetUpInProcessBrowserTestFixture() override {

DetectErrorsInJavaScript(); // Look for errors in our rather complex js.

}

- virtual void SetUpCommandLine(CommandLine* command_line) override {

+ void SetUpCommandLine(CommandLine* command_line) override {

// This test should run with fake devices.

command_line->AppendSwitch(switches::kUseFakeDeviceForMediaStream);