Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 664693002: Fix InstructionSelector to handle calls with no (used) output values. (Closed)

Created:
6 years, 2 months ago by titzer
Modified:
6 years, 2 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix InstructionSelector to handle calls with no (used) output values. R=jarin@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=24689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -9 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
A + test/mjsunit/unused-context-in-with.js View 1 chunk +6 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
titzer
6 years, 2 months ago (2014-10-17 11:12:11 UTC) #1
Jarin
lgtm
6 years, 2 months ago (2014-10-17 11:23:53 UTC) #2
titzer
6 years, 2 months ago (2014-10-17 11:26:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 24689 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698