Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: src/compiler/ia32/instruction-selector-ia32.cc

Issue 664693002: Fix InstructionSelector to handle calls with no (used) output values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/instruction-selector-impl.h" 5 #include "src/compiler/instruction-selector-impl.h"
6 #include "src/compiler/node-matchers.h" 6 #include "src/compiler/node-matchers.h"
7 #include "src/compiler/node-properties-inl.h" 7 #include "src/compiler/node-properties-inl.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 620 matching lines...) Expand 10 before | Expand all | Expand 10 after
631 case CallDescriptor::kCallJSFunction: 631 case CallDescriptor::kCallJSFunction:
632 opcode = kArchCallJSFunction; 632 opcode = kArchCallJSFunction;
633 break; 633 break;
634 default: 634 default:
635 UNREACHABLE(); 635 UNREACHABLE();
636 return; 636 return;
637 } 637 }
638 opcode |= MiscField::encode(descriptor->flags()); 638 opcode |= MiscField::encode(descriptor->flags());
639 639
640 // Emit the call instruction. 640 // Emit the call instruction.
641 InstructionOperand** first_output =
642 buffer.outputs.size() > 0 ? &buffer.outputs.front() : NULL;
641 Instruction* call_instr = 643 Instruction* call_instr =
642 Emit(opcode, buffer.outputs.size(), &buffer.outputs.front(), 644 Emit(opcode, buffer.outputs.size(), first_output,
643 buffer.instruction_args.size(), &buffer.instruction_args.front()); 645 buffer.instruction_args.size(), &buffer.instruction_args.front());
644 call_instr->MarkAsCall(); 646 call_instr->MarkAsCall();
645 } 647 }
646 648
647 649
648 // Shared routine for multiple compare operations. 650 // Shared routine for multiple compare operations.
649 static inline void VisitCompare(InstructionSelector* selector, 651 static inline void VisitCompare(InstructionSelector* selector,
650 InstructionCode opcode, 652 InstructionCode opcode,
651 InstructionOperand* left, 653 InstructionOperand* left,
652 InstructionOperand* right, 654 InstructionOperand* right,
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after
866 868
867 869
868 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) { 870 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) {
869 FlagsContinuation cont(kUnorderedLessThanOrEqual, node); 871 FlagsContinuation cont(kUnorderedLessThanOrEqual, node);
870 VisitFloat64Compare(this, node, &cont); 872 VisitFloat64Compare(this, node, &cont);
871 } 873 }
872 874
873 } // namespace compiler 875 } // namespace compiler
874 } // namespace internal 876 } // namespace internal
875 } // namespace v8 877 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/arm64/instruction-selector-arm64.cc ('k') | src/compiler/mips/instruction-selector-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698