Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Side by Side Diff: src/compiler/arm/instruction-selector-arm.cc

Issue 664693002: Fix InstructionSelector to handle calls with no (used) output values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/bits.h" 5 #include "src/base/bits.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 850 matching lines...) Expand 10 before | Expand all | Expand 10 after
861 case CallDescriptor::kCallJSFunction: 861 case CallDescriptor::kCallJSFunction:
862 opcode = kArchCallJSFunction; 862 opcode = kArchCallJSFunction;
863 break; 863 break;
864 default: 864 default:
865 UNREACHABLE(); 865 UNREACHABLE();
866 return; 866 return;
867 } 867 }
868 opcode |= MiscField::encode(descriptor->flags()); 868 opcode |= MiscField::encode(descriptor->flags());
869 869
870 // Emit the call instruction. 870 // Emit the call instruction.
871 InstructionOperand** first_output =
872 buffer.outputs.size() > 0 ? &buffer.outputs.front() : NULL;
871 Instruction* call_instr = 873 Instruction* call_instr =
872 Emit(opcode, buffer.outputs.size(), &buffer.outputs.front(), 874 Emit(opcode, buffer.outputs.size(), first_output,
873 buffer.instruction_args.size(), &buffer.instruction_args.front()); 875 buffer.instruction_args.size(), &buffer.instruction_args.front());
874 call_instr->MarkAsCall(); 876 call_instr->MarkAsCall();
875 } 877 }
876 878
877 879
878 namespace { 880 namespace {
879 881
880 // Shared routine for multiple float compare operations. 882 // Shared routine for multiple float compare operations.
881 void VisitFloat64Compare(InstructionSelector* selector, Node* node, 883 void VisitFloat64Compare(InstructionSelector* selector, Node* node,
882 FlagsContinuation* cont) { 884 FlagsContinuation* cont) {
(...skipping 280 matching lines...) Expand 10 before | Expand all | Expand 10 after
1163 1165
1164 1166
1165 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) { 1167 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) {
1166 FlagsContinuation cont(kUnorderedLessThanOrEqual, node); 1168 FlagsContinuation cont(kUnorderedLessThanOrEqual, node);
1167 VisitFloat64Compare(this, node, &cont); 1169 VisitFloat64Compare(this, node, &cont);
1168 } 1170 }
1169 1171
1170 } // namespace compiler 1172 } // namespace compiler
1171 } // namespace internal 1173 } // namespace internal
1172 } // namespace v8 1174 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/compiler/arm64/instruction-selector-arm64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698