Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/compiler/mips/instruction-selector-mips.cc

Issue 664693002: Fix InstructionSelector to handle calls with no (used) output values. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/base/bits.h" 5 #include "src/base/bits.h"
6 #include "src/compiler/instruction-selector-impl.h" 6 #include "src/compiler/instruction-selector-impl.h"
7 #include "src/compiler/node-matchers.h" 7 #include "src/compiler/node-matchers.h"
8 8
9 namespace v8 { 9 namespace v8 {
10 namespace internal { 10 namespace internal {
(...skipping 433 matching lines...) Expand 10 before | Expand all | Expand 10 after
444 case CallDescriptor::kCallJSFunction: 444 case CallDescriptor::kCallJSFunction:
445 opcode = kArchCallJSFunction; 445 opcode = kArchCallJSFunction;
446 break; 446 break;
447 default: 447 default:
448 UNREACHABLE(); 448 UNREACHABLE();
449 return; 449 return;
450 } 450 }
451 opcode |= MiscField::encode(descriptor->flags()); 451 opcode |= MiscField::encode(descriptor->flags());
452 452
453 // Emit the call instruction. 453 // Emit the call instruction.
454 InstructionOperand** first_output =
455 buffer.outputs.size() > 0 ? &buffer.outputs.front() : NULL;
454 Instruction* call_instr = 456 Instruction* call_instr =
455 Emit(opcode, buffer.outputs.size(), &buffer.outputs.front(), 457 Emit(opcode, buffer.outputs.size(), first_output,
456 buffer.instruction_args.size(), &buffer.instruction_args.front()); 458 buffer.instruction_args.size(), &buffer.instruction_args.front());
457 call_instr->MarkAsCall(); 459 call_instr->MarkAsCall();
458 } 460 }
459 461
460 462
461 namespace { 463 namespace {
462 464
463 // Shared routine for multiple compare operations. 465 // Shared routine for multiple compare operations.
464 static void VisitCompare(InstructionSelector* selector, InstructionCode opcode, 466 static void VisitCompare(InstructionSelector* selector, InstructionCode opcode,
465 InstructionOperand* left, InstructionOperand* right, 467 InstructionOperand* left, InstructionOperand* right,
(...skipping 175 matching lines...) Expand 10 before | Expand all | Expand 10 after
641 643
642 644
643 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) { 645 void InstructionSelector::VisitFloat64LessThanOrEqual(Node* node) {
644 FlagsContinuation cont(kUnorderedLessThanOrEqual, node); 646 FlagsContinuation cont(kUnorderedLessThanOrEqual, node);
645 VisitFloat64Compare(this, node, &cont); 647 VisitFloat64Compare(this, node, &cont);
646 } 648 }
647 649
648 } // namespace compiler 650 } // namespace compiler
649 } // namespace internal 651 } // namespace internal
650 } // namespace v8 652 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ia32/instruction-selector-ia32.cc ('k') | src/compiler/x64/instruction-selector-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698