Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 663003002: Revert of Implement suspend/resume for AudioContext (Closed)

Created:
6 years, 2 months ago by dstockwell
Modified:
6 years, 2 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

Revert of Implement suspend/resume for AudioContext (patchset #13 id:260001 of https://codereview.chromium.org/625363004/) Reason for revert: Breaks webaudio/oscillator-sine.html on Windows Original issue's description: > Implement suspend/resume for AudioContext > > WebAudio is adding a suspend()/resume() API: > > https://github.com/WebAudio/web-audio-api/issues/361 > https://github.com/WebAudio/web-audio-api/issues/317 > > In more detail, here is the proposed additions to the spec: > > New attribute "state" with values: > paused > Currently paused (time is not proceeding, audio hardware may be powered down/released). > running > Audio is being processed. > released > AudioContext has been released, and can no longer be used to process audio. All system resources should be released. > > void suspend() > Suspends the progression of time in the audio context, allows any current buffer contents to be played to the destination and then allows the system to power down and/or release audio hardware. If the context has been released, an InvalidStateError MUST be thrown. This is generally useful when the application knows it will not need the AudioContext for some time, and wishes to let the audio hardware power down. > > While the system is suspend, MediaStreams will have their output ignored; that is, data will be lost by the real time nature of media streams. HTMLMediaElements will similarly have their output ignored until the system is resumed. Audio Workers and ScriptProcessorNodes will simply not fire their onaudioprocess events while suspended, but will resume when resumed. For the purpose of AnalyserNode window functions, the data is considered as a continuous stream - i.e. the resume()/suspend() does not cause silence to appear in the AnalyserNode's stream of data. > > Promise resume() > Resumes the progression of time in the audio context, which may involve re-priming the frame buffer contents. The promise resolves when the system has re-acquired (if necessary) access to audio hardware and has begun streaming to the destination, or immediately (with no other effect) if the context is already running. The promise is rejected if the context has been released. > > BUG=420106 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183916 TBR=haraken@chromium.org,tkent@chromium.org,yhirano@chromium.org,rtoy@chromium.org NOTREECHECKS=true NOTRY=true BUG=420106 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183953

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -330 lines) Patch
D LayoutTests/webaudio/audiocontext-suspend-resume.html View 1 chunk +0 lines, -93 lines 0 comments Download
D LayoutTests/webaudio/audiocontext-suspend-resume-expected.txt View 1 chunk +0 lines, -23 lines 0 comments Download
M Source/modules/webaudio/AudioContext.h View 6 chunks +0 lines, -36 lines 0 comments Download
M Source/modules/webaudio/AudioContext.cpp View 10 chunks +2 lines, -145 lines 0 comments Download
M Source/modules/webaudio/AudioContext.idl View 3 chunks +0 lines, -13 lines 0 comments Download
M Source/modules/webaudio/AudioDestinationNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +1 line, -12 lines 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/webaudio/OfflineAudioDestinationNode.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dstockwell
Created Revert of Implement suspend/resume for AudioContext
6 years, 2 months ago (2014-10-19 23:34:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/663003002/1
6 years, 2 months ago (2014-10-19 23:34:57 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183953
6 years, 2 months ago (2014-10-19 23:35:33 UTC) #3
haraken
6 years, 2 months ago (2014-10-20 00:01:54 UTC) #4
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698