|
Add infrastructure for Chrome Actions
Chrome Actions are designed to be actions that live on the
toolbar, like extension actions, but are actually components
of Chrome. Examples of this can be ChromeCast, Translate,
Password Manager, etc. This change partially implements the basic
infrastructure for these actions.
(The main goal of this patch is to provide a shell that
the chromecast team can expand upon and use to prototype.)
* Create a generic ToolbarActionViewController, which can
be implemented by a specific chrome action or to handle
the general extensions case.
* (Mostly) abstract the concept of extensions out of the
BrowserActionView, so it can be used for either extension
actions or chrome actions.
* Create a simple ChromeActionsRegistry.
* Display chrome actions in the overflow menu of the browser
actions container.
Known limitations:
* Chrome actions cannot be reordered, dragged, or shown in
the main action toolbar (we need to consolidate chrome
actions with the extension toolbar in the model somehow).
BUG= 422976
Committed: https://crrev.com/3ab2d3060f13924948f3072936b4aea5aacd12b4
Cr-Commit-Position: refs/heads/master@{#300500}
Total comments: 26
Total comments: 15
Total comments: 5
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+808 lines, -480 lines) |
Patch |
 |
M |
chrome/browser/extensions/browser_action_test_util.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_toolbar_model.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_toolbar_model.cc
|
View
|
1
2
3
|
4 chunks |
+13 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_toolbar_model_unittest.cc
|
View
|
1
2
3
|
8 chunks |
+9 lines, -9 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/browser_action_test_util_mac.mm
|
View
|
1
2
3
|
1 chunk |
+0 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/toolbar/component_toolbar_actions_factory.h
|
View
|
1
2
3
|
1 chunk |
+37 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/toolbar/component_toolbar_actions_factory.cc
|
View
|
1
2
|
1 chunk |
+51 lines, -0 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/toolbar/toolbar_action_view_controller.h
|
View
|
1
2
3
|
1 chunk |
+89 lines, -0 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/extensions/extension_action_view_controller.h
|
View
|
1
2
3
|
10 chunks |
+50 lines, -29 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/extensions/extension_action_view_controller.cc
|
View
|
1
2
3
|
10 chunks |
+139 lines, -39 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/extensions/extension_action_view_delegate.h
|
View
|
|
1 chunk |
+0 lines, -71 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/location_bar/page_action_image_view.h
|
View
|
1
2
3
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/location_bar/page_action_image_view.cc
|
View
|
1
2
3
|
7 chunks |
+10 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc
|
View
|
1
2
3
|
4 chunks |
+9 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_action_view.h
|
View
|
1
2
3
|
6 chunks |
+24 lines, -54 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_action_view.cc
|
View
|
1
2
3
4
|
10 chunks |
+44 lines, -105 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_actions_container.h
|
View
|
1
2
3
|
2 chunks |
+6 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_actions_container.cc
|
View
|
1
2
3
4
|
14 chunks |
+89 lines, -35 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
|
View
|
1
2
3
|
9 chunks |
+38 lines, -39 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/toolbar/chevron_menu_button.cc
|
View
|
1
2
3
|
7 chunks |
+33 lines, -34 lines |
0 comments
|
Download
|
 |
A |
chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc
|
View
|
1
2
3
|
1 chunk |
+142 lines, -0 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/views/toolbar/toolbar_action_view_delegate.h
|
View
|
1
2
|
5 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
2
3
4
|
3 chunks |
+4 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests.gypi
|
View
|
1
2
3
4
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
Total messages: 28 (7 generated)
|