Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: chrome/browser/ui/toolbar/browser_actions_bar_browsertest.cc

Issue 661493004: Add infrastructure for Chrome Actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h" 5 #include "chrome/browser/ui/toolbar/browser_actions_bar_browsertest.h"
6 6
7 #include "chrome/browser/extensions/browser_action_test_util.h" 7 #include "chrome/browser/extensions/browser_action_test_util.h"
8 #include "chrome/browser/extensions/extension_browsertest.h" 8 #include "chrome/browser/extensions/extension_browsertest.h"
9 #include "chrome/browser/extensions/extension_service.h" 9 #include "chrome/browser/extensions/extension_service.h"
10 #include "chrome/browser/extensions/extension_toolbar_model.h" 10 #include "chrome/browser/extensions/extension_toolbar_model.h"
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
110 extensions::ExtensionToolbarModel* model = 110 extensions::ExtensionToolbarModel* model =
111 extensions::ExtensionToolbarModel::Get(profile()); 111 extensions::ExtensionToolbarModel::Get(profile());
112 ASSERT_TRUE(model); 112 ASSERT_TRUE(model);
113 113
114 // Order is now A B C. 114 // Order is now A B C.
115 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); 115 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0));
116 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); 116 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1));
117 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(2)); 117 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(2));
118 118
119 // Move C to first position. Order is C A B. 119 // Move C to first position. Order is C A B.
120 model->MoveExtensionIcon(extension_c(), 0); 120 model->MoveExtensionIcon(extension_c()->id(), 0);
121 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); 121 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0));
122 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1)); 122 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1));
123 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2)); 123 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2));
124 124
125 // Move B to third position. Order is still C A B. 125 // Move B to third position. Order is still C A B.
126 model->MoveExtensionIcon(extension_b(), 2); 126 model->MoveExtensionIcon(extension_b()->id(), 2);
127 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); 127 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0));
128 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1)); 128 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(1));
129 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2)); 129 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(2));
130 130
131 // Move B to middle position. Order is C B A. 131 // Move B to middle position. Order is C B A.
132 model->MoveExtensionIcon(extension_b(), 1); 132 model->MoveExtensionIcon(extension_b()->id(), 1);
133 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0)); 133 EXPECT_EQ(extension_c()->id(), browser_actions_bar()->GetExtensionId(0));
134 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1)); 134 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(1));
135 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(2)); 135 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(2));
136 } 136 }
137 137
138 // Test that explicitly hiding an extension action results in it disappearing 138 // Test that explicitly hiding an extension action results in it disappearing
139 // from the browser actions bar. 139 // from the browser actions bar.
140 IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, ForceHide) { 140 IN_PROC_BROWSER_TEST_F(BrowserActionsBarBrowserTest, ForceHide) {
141 LoadExtensions(); 141 LoadExtensions();
142 142
143 EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions()); 143 EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions());
144 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0)); 144 EXPECT_EQ(extension_a()->id(), browser_actions_bar()->GetExtensionId(0));
145 // Force hide one of the extensions' browser action. 145 // Force hide one of the extensions' browser action.
146 extensions::ExtensionActionAPI::SetBrowserActionVisibility( 146 extensions::ExtensionActionAPI::SetBrowserActionVisibility(
147 extensions::ExtensionPrefs::Get(browser()->profile()), 147 extensions::ExtensionPrefs::Get(browser()->profile()),
148 extension_a()->id(), 148 extension_a()->id(),
149 false); 149 false);
150 // The browser action for Extension A should be removed. 150 // The browser action for Extension A should be removed.
151 EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions()); 151 EXPECT_EQ(2, browser_actions_bar()->VisibleBrowserActions());
152 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(0)); 152 EXPECT_EQ(extension_b()->id(), browser_actions_bar()->GetExtensionId(0));
153 } 153 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698