chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm - Issue 661493004: Add infrastructure for Chrome Actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

Issue 661493004: Add infrastructure for Chrome Actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

diff --git a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

index 67b28fb77a8dbe8378c6a5e372590bbce56d37d0..6e36fce5fbf2d3d30bf4c903774f13b68f7ee2c3 100644

--- a/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

+++ b/chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm

@@ -699,7 +699,7 @@ class ExtensionServiceObserverBridge

if (intersectionWidth > dragThreshold && button != draggedButton &&

![button isAnimating] && index < [self visibleButtonCount]) {

- toolbarModel_->MoveExtensionIcon([draggedButton extension], index);

+ toolbarModel_->MoveExtensionIcon([draggedButton extension]->id(), index);

[self positionActionButtonsAndAnimate:YES];

return;

}