chrome/browser/extensions/extension_toolbar_model.h - Issue 661493004: Add infrastructure for Chrome Actions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_toolbar_model.h

Issue 661493004: Add infrastructure for Chrome Actions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_toolbar_model.h

diff --git a/chrome/browser/extensions/extension_toolbar_model.h b/chrome/browser/extensions/extension_toolbar_model.h

index c9d975df632a0fcec5ea65d212e1b2c6d9294e15..d25f48c77393b8ddbccf319621dd7a1ba0223b35 100644

--- a/chrome/browser/extensions/extension_toolbar_model.h

+++ b/chrome/browser/extensions/extension_toolbar_model.h

@@ -93,7 +93,7 @@ class ExtensionToolbarModel : public content::NotificationObserver,

void RemoveObserver(Observer* observer);

// Moves the given |extension|'s icon to the given |index|.

- void MoveExtensionIcon(const Extension* extension, size_t index);

+ void MoveExtensionIcon(const std::string& id, size_t index);

// Sets the number of extension icons that should be visible.

// If count == size(), this will set the visible icon count to -1, meaning