[Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

[Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

BUG=422814
TEST=None

Committed: https://crrev.com/2175c6257dd81a2b27af34e7f617f35a024ac5bb
Cr-Commit-Position: refs/heads/master@{#300732}

[pkotwicz, 2014-10-15 23:31:09]

Patchset #1 (id:1) has been deleted

[pkotwicz, 2014-10-15 23:39:23]

pkotwicz@chromium.org changed reviewers:
+ asargent@chromium.org

[pkotwicz, 2014-10-15 23:39:24]

asargent@ can you please take a look?

Moving the code for browser creation to
ExtensionInstallDialogView::LinkClicked() is useful:
- for Athena (less places which need Athena specific handling)
- for fixing crbug.com/422814 (because the ShowParams values may be invalid by
the time that the dialog is shown)

I do not think that the OpenURL() overrides that I removed were ever hit

[pkotwicz, 2014-10-15 23:39:29]

Patchset #1 (id:20001) has been deleted

[pkotwicz, 2014-10-15 23:54:19]

Patchset #1 (id:40001) has been deleted

[pkotwicz, 2014-10-17 16:01:21]

asargent@ Ping!

[asargent_no_longer_on_chrome, 2014-10-20 20:12:50]

Apologies for the delay.

extensions parts LGTM

[pkotwicz, 2014-10-21 14:42:46]

pkotwicz@chromium.org changed reviewers:
+ sky@chromium.org

[pkotwicz, 2014-10-21 14:42:48]

sky@ for chrome/browser/apps and chrome/browser/ui OWNERS

[sky, 2014-10-21 18:04:24]

LGTM

https://codereview.chromium.org/660643002/diff/100001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm
(right):

https://codereview.chromium.org/660643002/diff/100001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm:39:
delegate:this
nit: spacing is off here.

[pkotwicz, 2014-10-21 18:45:02]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-21 18:46:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660643002/120001

[commit-bot: I haz the power, 2014-10-21 19:33:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-21 19:33:35]

Try jobs failed on following builders:
  mac_chromium_compile_dbg on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[pkotwicz, 2014-10-21 20:44:54]

Patchset #5 (id:140001) has been deleted

[pkotwicz, 2014-10-22 14:33:18]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-22 14:33:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660643002/160001

[commit-bot: I haz the power, 2014-10-22 18:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-22 18:39:51]

Try jobs failed on following builders:
  linux_chromium_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pkotwicz, 2014-10-22 18:44:29]

The CQ bit was checked by pkotwicz@chromium.org

[commit-bot: I haz the power, 2014-10-22 18:47:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/660643002/160001

[commit-bot: I haz the power, 2014-10-22 19:56:42]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2014-10-22 19:58:20]

Patchset 5 (id:??) landed as
https://crrev.com/2175c6257dd81a2b27af34e7f617f35a024ac5bb
Cr-Commit-Position: refs/heads/master@{#300732}