[Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/extensions/windowed_install_dialog_controller.h"
 
 #import "base/mac/sdk_forward_declarations.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/sys_string_conversions.h"
+#include "chrome/browser/profiles/profile.h"
 #import "chrome/browser/ui/cocoa/extensions/extension_install_view_controller.h"
+#include "content/public/browser/web_contents.h"
 #include "ui/base/cocoa/window_size_constants.h"
 
 @interface WindowedInstallController
     : NSWindowController<NSWindowDelegate> {
  @private
   base::scoped_nsobject<ExtensionInstallViewController> installViewController_;
   WindowedInstallDialogController* dialogController_;  // Weak. Owns us.
 }
 
 @property(readonly, nonatomic) ExtensionInstallViewController* viewController;
 
-- (id)initWithNavigator:(content::PageNavigator*)navigator
-               delegate:(WindowedInstallDialogController*)delegate
-                 prompt:(scoped_refptr<ExtensionInstallPrompt::Prompt>)prompt;
+- (id)initWithProfile:(Profile*)profile
+            navigator:(content::PageNavigator*)navigator
+             delegate:(WindowedInstallDialogController*)delegate
+               prompt:(scoped_refptr<ExtensionInstallPrompt::Prompt>)prompt;
 
 @end
 
 WindowedInstallDialogController::WindowedInstallDialogController(
     const ExtensionInstallPrompt::ShowParams& show_params,
     ExtensionInstallPrompt::Delegate* delegate,
     scoped_refptr<ExtensionInstallPrompt::Prompt> prompt)
     : delegate_(delegate) {
   install_controller_.reset([[WindowedInstallController alloc]
-      initWithNavigator:show_params.navigator
+      initWithProfile:show_params.profile
+            navigator:show_params.parent_web_contents
                delegate:this

[sky, 2014/10/21 18:04:24]

nit: spacing is off here.

                  prompt:prompt]);
   [[install_controller_ window] makeKeyAndOrderFront:nil];
 }
 
 WindowedInstallDialogController::~WindowedInstallDialogController() {
   DCHECK(!install_controller_);
   DCHECK(!delegate_);
 }
 
 void WindowedInstallDialogController::OnWindowClosing() {
@@ skipping 17 matching lines @@
 }
 
 void WindowedInstallDialogController::InstallUIAbort(bool user_initiated) {
   delegate_->InstallUIAbort(user_initiated);
   delegate_ = NULL;
   [[install_controller_ window] close];
 }
 
 @implementation WindowedInstallController
 
-- (id)initWithNavigator:(content::PageNavigator*)navigator
-               delegate:(WindowedInstallDialogController*)delegate
-                 prompt:(scoped_refptr<ExtensionInstallPrompt::Prompt>)prompt {
+- (id)initWithProfile:(Profile*)profile
+            navigator:(content::PageNavigator*)navigator
+             delegate:(WindowedInstallDialogController*)delegate
+               prompt:(scoped_refptr<ExtensionInstallPrompt::Prompt>)prompt {
   base::scoped_nsobject<NSWindow> controlledPanel(
       [[NSPanel alloc] initWithContentRect:ui::kWindowSizeDeterminedLater
                                  styleMask:NSTitledWindowMask
                                    backing:NSBackingStoreBuffered
                                      defer:NO]);
   if ((self = [super initWithWindow:controlledPanel])) {
     dialogController_ = delegate;
     installViewController_.reset([[ExtensionInstallViewController alloc]
-        initWithNavigator:navigator
-                 delegate:delegate
-                   prompt:prompt]);
+        initWithProfile:profile
+              navigator:navigator
+               delegate:delegate
+                 prompt:prompt]);
     NSWindow* window = [self window];
 
     // Ensure the window does not display behind the app launcher window, and is
     // otherwise hard to lose behind other windows (since it is not modal).
     [window setLevel:NSDockWindowLevel];
 
     // Animate the window when ordered in, the same way as an NSAlert.
     if ([window respondsToSelector:@selector(setAnimationBehavior:)])
       [window setAnimationBehavior:NSWindowAnimationBehaviorAlertPanel];
 
@@ skipping 11 matching lines @@
 - (ExtensionInstallViewController*)viewController {
   return installViewController_;
 }
 
 - (void)windowWillClose:(NSNotification*)notification {
   [[self window] setDelegate:nil];
   dialogController_->OnWindowClosing();
 }
 
 @end