Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3463)

Unified Diff: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
index 7758f01620ad0a0e53dfd04327f3fef08b056fd3..584101ee193d650bd7fe28efd2dbfe87a5a46d4c 100644
--- a/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/extensions/extension_install_view_controller_unittest.mm
@@ -48,9 +48,10 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalCancel) {
prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
- [[ExtensionInstallViewController alloc] initWithNavigator:browser()
- delegate:&delegate
- prompt:prompt]);
+ [[ExtensionInstallViewController alloc] initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate
+ prompt:prompt]);
[controller view]; // Force nib load.
@@ -106,9 +107,10 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsNormalOK) {
prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
- [[ExtensionInstallViewController alloc] initWithNavigator:browser()
- delegate:&delegate
- prompt:prompt]);
+ [[ExtensionInstallViewController alloc] initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate
+ prompt:prompt]);
[controller view]; // Force nib load.
[controller ok:nil];
@@ -146,17 +148,19 @@ TEST_F(ExtensionInstallViewControllerTest, MultipleWarnings) {
base::scoped_nsobject<ExtensionInstallViewController> controller1(
[[ExtensionInstallViewController alloc]
- initWithNavigator:browser()
- delegate:&delegate1
- prompt:one_warning_prompt]);
+ initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate1
+ prompt:one_warning_prompt]);
[controller1 view]; // Force nib load.
base::scoped_nsobject<ExtensionInstallViewController> controller2(
[[ExtensionInstallViewController alloc]
- initWithNavigator:browser()
- delegate:&delegate2
- prompt:two_warnings_prompt]);
+ initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate2
+ prompt:two_warnings_prompt]);
[controller2 view]; // Force nib load.
@@ -181,9 +185,10 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsSkinny) {
base::scoped_nsobject<ExtensionInstallViewController> controller(
[[ExtensionInstallViewController alloc]
- initWithNavigator:browser()
- delegate:&delegate
- prompt:no_warnings_prompt]);
+ initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate
+ prompt:no_warnings_prompt]);
[controller view]; // Force nib load.
@@ -225,9 +230,10 @@ TEST_F(ExtensionInstallViewControllerTest, BasicsInline) {
inline_prompt->set_icon(chrome::LoadInstallPromptIcon());
base::scoped_nsobject<ExtensionInstallViewController> controller(
- [[ExtensionInstallViewController alloc] initWithNavigator:browser()
- delegate:&delegate
- prompt:inline_prompt]);
+ [[ExtensionInstallViewController alloc] initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate
+ prompt:inline_prompt]);
[controller view]; // Force nib load.
@@ -288,9 +294,10 @@ TEST_F(ExtensionInstallViewControllerTest, PostInstallPermissionsPrompt) {
prompt->SetPermissionsDetails(details, type);
base::scoped_nsobject<ExtensionInstallViewController> controller(
- [[ExtensionInstallViewController alloc] initWithNavigator:browser()
- delegate:&delegate
- prompt:prompt]);
+ [[ExtensionInstallViewController alloc] initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate
+ prompt:prompt]);
[controller view]; // Force nib load.
@@ -320,9 +327,10 @@ TEST_F(ExtensionInstallViewControllerTest, PermissionsDetails) {
ExtensionInstallPrompt::PERMISSIONS_DETAILS, 0, true);
base::scoped_nsobject<ExtensionInstallViewController> controller(
- [[ExtensionInstallViewController alloc] initWithNavigator:browser()
- delegate:&delegate
- prompt:prompt]);
+ [[ExtensionInstallViewController alloc] initWithProfile:profile()
+ navigator:browser()
+ delegate:&delegate
+ prompt:prompt]);
[controller view]; // Force nib load.

Powered by Google App Engine
This is Rietveld 408576698