chrome/browser/extensions/external_install_error.cc - Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/external_install_error.cc

Issue 660643002: [Refactor] Move creating a browser if necessary to ExtensionInstallDialogView (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/external_install_error.cc

diff --git a/chrome/browser/extensions/external_install_error.cc b/chrome/browser/extensions/external_install_error.cc

index 73ce2e8f1c462fad7605064fdc9950ebac89ec61..2cb0d06c1522d52c0c8c0f9de6e3841283d309fe 100644

--- a/chrome/browser/extensions/external_install_error.cc

+++ b/chrome/browser/extensions/external_install_error.cc

@@ -366,8 +366,7 @@ void ExternalInstallError::OnFetchComplete() {

// to pass ones which may be invalidated.

install_ui_.reset(

new ExtensionInstallPrompt(Profile::FromBrowserContext(browser_context_),

- NULL, // NULL native window.

- NULL)); // NULL navigator.

+ NULL)); // NULL native window.

install_ui_->ConfirmExternalInstall(

this,

« no previous file with comments | « chrome/browser/extensions/extension_install_prompt.cc ('k') | chrome/browser/extensions/unpacked_installer.cc » ('j') | no next file with comments »