Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 659443007: Support GLSL es 3.00 (Closed)

Created:
6 years, 2 months ago by joshua.litt
Modified:
6 years, 2 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : bug war #

Total comments: 4

Patch Set 3 : feedback inc #

Patch Set 4 : fix #

Patch Set 5 : nvpr fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -13 lines) Patch
M src/gpu/gl/GrGLCaps.cpp View 1 2 chunks +4 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLContext.cpp View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLSL.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/gpu/gl/GrGLSL.cpp View 1 2 3 4 3 chunks +21 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGLShaderVar.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
joshualitt
6 years, 2 months ago (2014-10-15 23:46:50 UTC) #2
bsalomon
https://codereview.chromium.org/659443007/diff/20001/src/gpu/gl/GrGLContext.cpp File src/gpu/gl/GrGLContext.cpp (right): https://codereview.chromium.org/659443007/diff/20001/src/gpu/gl/GrGLContext.cpp#newcode51 src/gpu/gl/GrGLContext.cpp:51: * Qualcomm drivers have a horrendous bug with some ...
6 years, 2 months ago (2014-10-16 01:41:35 UTC) #3
joshualitt
feedback inc
6 years, 2 months ago (2014-10-16 16:56:09 UTC) #4
bsalomon
lgtm
6 years, 2 months ago (2014-10-16 18:14:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/659443007/80001
6 years, 2 months ago (2014-10-16 19:18:50 UTC) #7
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 62372bcc6abe3537dac98dd9b9172cf3b85afa2b
6 years, 2 months ago (2014-10-16 19:25:16 UTC) #8
rmistry
6 years, 2 months ago (2014-10-17 12:13:28 UTC) #9
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/661603009/ by rmistry@google.com.

The reason for reverting is: Trying to fix DEPS roll failure:
https://codereview.chromium.org/660113002/

Link to failing builds:
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/2...
http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/2....

Powered by Google App Engine
This is Rietveld 408576698