Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 657763002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
jamesr
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, eme-reviews_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, posciak+watch_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/4b6b5ff0fe1f0bb9c06290462253704bd816aa5d Cr-Commit-Position: refs/heads/master@{#299797}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -48 lines) Patch
M content/renderer/browser_render_view_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/gpu/frame_swap_message_queue_unittest.cc View 3 chunks +4 lines, -7 lines 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 4 chunks +8 lines, -12 lines 0 comments Download
M content/renderer/java/gin_java_bridge_value_converter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/crypto/content_decryption_module_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/crypto/ppapi_decryptor.cc View 2 chunks +5 lines, -8 lines 0 comments Download
M content/renderer/media/crypto/proxy_media_keys.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/pepper/content_decryptor_delegate.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/render_widget.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dcheng
6 years, 2 months ago (2014-10-15 17:13:42 UTC) #2
jamesr
lgtm make_scoped_ptr(...).PassAs<...>() was the saddest thing
6 years, 2 months ago (2014-10-15 23:15:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657763002/1
6 years, 2 months ago (2014-10-15 23:17:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-16 00:42:26 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-16 00:43:07 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4b6b5ff0fe1f0bb9c06290462253704bd816aa5d
Cr-Commit-Position: refs/heads/master@{#299797}

Powered by Google App Engine
This is Rietveld 408576698