content/renderer/java/gin_java_bridge_value_converter.cc - Issue 657763002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/java/gin_java_bridge_value_converter.cc

Issue 657763002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/gpu/gpu_benchmarking_extension.cc ('k') | content/renderer/media/crypto/content_decryption_module_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/java/gin_java_bridge_value_converter.cc

diff --git a/content/renderer/java/gin_java_bridge_value_converter.cc b/content/renderer/java/gin_java_bridge_value_converter.cc

index 79c521987c9d0e16c07be34431650ada18c8051e..c1727a42bb5681b3771ee7e4171f959ab94e4e30 100644

--- a/content/renderer/java/gin_java_bridge_value_converter.cc

+++ b/content/renderer/java/gin_java_bridge_value_converter.cc

@@ -68,9 +68,8 @@ class TypedArraySerializerImpl : public TypedArraySerializer {

public:

static scoped_ptr<TypedArraySerializer> Create(

v8::Handle<v8::TypedArray> typed_array) {

- scoped_ptr<TypedArraySerializerImpl<ElementType, ListType> > result(

+ return make_scoped_ptr(

new TypedArraySerializerImpl<ElementType, ListType>(typed_array));

- return result.template PassAs<TypedArraySerializer>();

}

virtual void serializeTo(char* data,