content/renderer/gpu/frame_swap_message_queue_unittest.cc - Issue 657763002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/frame_swap_message_queue_unittest.cc

Issue 657763002: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/gpu/frame_swap_message_queue_unittest.cc

diff --git a/content/renderer/gpu/frame_swap_message_queue_unittest.cc b/content/renderer/gpu/frame_swap_message_queue_unittest.cc

index c3ea468795dbba5c38d9322896db4426de01b49a..d8eeb5503a2119c29bcc9013f9eb9e5d70c9c1b6 100644

--- a/content/renderer/gpu/frame_swap_message_queue_unittest.cc

+++ b/content/renderer/gpu/frame_swap_message_queue_unittest.cc

@@ -263,9 +263,8 @@ class NotifiesDeletionMessage : public IPC::Message {

TEST_F(FrameSwapMessageQueueTest, TestDeletesNextSwapMessage) {

bool message_deleted = false;

- QueueNextSwapMessage(make_scoped_ptr(new NotifiesDeletionMessage(

- &message_deleted, first_message_))

- .PassAs<IPC::Message>());

+ QueueNextSwapMessage(make_scoped_ptr(

+ new NotifiesDeletionMessage(&message_deleted, first_message_)));

queue_ = NULL;

ASSERT_TRUE(message_deleted);

}

@@ -274,8 +273,7 @@ TEST_F(FrameSwapMessageQueueTest, TestDeletesVisualStateMessage) {

bool message_deleted = false;

QueueVisualStateMessage(1,

make_scoped_ptr(new NotifiesDeletionMessage(

- &message_deleted, first_message_))

- .PassAs<IPC::Message>());

+ &message_deleted, first_message_)));

queue_ = NULL;

ASSERT_TRUE(message_deleted);

}

@@ -284,8 +282,7 @@ TEST_F(FrameSwapMessageQueueTest, TestDeletesQueuedVisualStateMessage) {

bool message_deleted = false;

QueueVisualStateMessage(1,

make_scoped_ptr(new NotifiesDeletionMessage(

- &message_deleted, first_message_))

- .PassAs<IPC::Message>());

+ &message_deleted, first_message_)));

queue_->DidSwap(1);

queue_ = NULL;

ASSERT_TRUE(message_deleted);

« no previous file with comments | « content/renderer/gpu/frame_swap_message_queue.cc ('k') | content/renderer/gpu/gpu_benchmarking_extension.cc » ('j') | no next file with comments »