Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
jam, sky
CC:
aandrey+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, grt+watch_chromium.org, native-client-reviews_googlegroups.com, paulirish+reviews_chromium.org, pfeldman, samuong+watch_chromium.org, stgao, vsevik, wfh+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. BUG=423621 Committed: https://crrev.com/cbbca64fd4b278a6cfc6726042883e0aa292aab3 Cr-Commit-Position: refs/heads/master@{#300378}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 9 (3 generated)
dcheng
Pretty straightforward change. Just a cleanup to make it easier to convert to std::move() later. ...
6 years, 2 months ago (2014-10-16 21:48:48 UTC) #2
dcheng
+sky, mind taking a look at this?
6 years, 2 months ago (2014-10-20 20:27:26 UTC) #4
sky
LGTM
6 years, 2 months ago (2014-10-20 22:19:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/657313003/1
6 years, 2 months ago (2014-10-20 23:04:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 23:43:16 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 23:44:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbbca64fd4b278a6cfc6726042883e0aa292aab3
Cr-Commit-Position: refs/heads/master@{#300378}

Powered by Google App Engine
This is Rietveld 408576698