chrome/test/chromedriver/chrome/web_view_impl.cc - Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc ('K') | « chrome/test/chromedriver/chrome/log.cc ('k') | chrome/test/nacl/pnacl_header_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/web_view_impl.cc

diff --git a/chrome/test/chromedriver/chrome/web_view_impl.cc b/chrome/test/chromedriver/chrome/web_view_impl.cc

index 55c035f4b4beed39f38e1e61339a4529fae7226e..f1ab9b4d64347f0f6e47bc7dda88b0d5763b902c 100644

--- a/chrome/test/chromedriver/chrome/web_view_impl.cc

+++ b/chrome/test/chromedriver/chrome/web_view_impl.cc

@@ -489,7 +489,7 @@ Status WebViewImpl::EndProfile(scoped_ptr<base::Value>* profile_data) {

}

- *profile_data = profile_result.PassAs<base::Value>();

+ *profile_data = profile_result.Pass();

return status;

}