chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc - Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_dom_feature_extractor_browsertest.cc ('k') | chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

diff --git a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

index c7b30ff50e9d233db56bc3f29eb64d6b70def60e..3f7aba7eb3512b1956b6b8ad665996084aa73436 100644

--- a/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

+++ b/chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc

@@ -1043,8 +1043,7 @@ class MockDevToolsEventListener : public DevToolsEventListener {

scoped_ptr<SyncWebSocket> CreateMockSyncWebSocket6(

std::list<std::string>* messages) {

- return scoped_ptr<MockSyncWebSocket6>(new MockSyncWebSocket6(messages))

- .PassAs<SyncWebSocket>();

+ return make_scoped_ptr(new MockSyncWebSocket6(messages));

dcheng 2014/10/16 21:48:48 This doesn't need to use Pass() at all, so I just

}

} // namespace