chrome/test/chromedriver/chrome/log.cc - Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/chromedriver/chrome/log.cc

Issue 657313003: Use scoped_ptr::Pass instead of scoped_ptr::PassAs<T>. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc ('K') | « chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc ('k') | chrome/test/chromedriver/chrome/web_view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/chromedriver/chrome/log.cc

diff --git a/chrome/test/chromedriver/chrome/log.cc b/chrome/test/chromedriver/chrome/log.cc

index 75ed25b0b148f69d0a4c9e7fe472cb5ba6959554..a40f9b2d786ff954ec6914bb50ccc36264155624 100644

--- a/chrome/test/chromedriver/chrome/log.cc

+++ b/chrome/test/chromedriver/chrome/log.cc

@@ -49,7 +49,7 @@ scoped_ptr<base::Value> SmartDeepCopy(const base::Value* value) {

dict_copy->SetWithoutPathExpansion(it.key(),

SmartDeepCopy(child).release());

}

- return dict_copy.PassAs<base::Value>();

+ return dict_copy.Pass();

} else if (value->GetAsList(&list)) {

scoped_ptr<base::ListValue> list_copy(new base::ListValue());

for (size_t i = 0; i < list->GetSize(); ++i) {

@@ -62,7 +62,7 @@ scoped_ptr<base::Value> SmartDeepCopy(const base::Value* value) {

}

list_copy->Append(SmartDeepCopy(child).release());

}

- return list_copy.PassAs<base::Value>();

+ return list_copy.Pass();

} else if (value->GetAsString(&data)) {

TruncateString(&data);

return scoped_ptr<base::Value>(new base::StringValue(data));