Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, rginda+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/browser/profiles/ The Google C++ style guide states: Explicitly annotate overrides of virtual functions or virtual destructors with an override or (less frequently) final specifier. Older (pre-C++11) code will use the virtual keyword as an inferior alternative annotation. For clarity, use exactly one of override, final, or virtual when declaring an override. To better conform to these guidelines, the following constructs have been rewritten: - if a base class has a virtual destructor, then: virtual ~Foo(); -> ~Foo() override; - virtual void Foo() override; -> void Foo() override; - virtual void Foo() override final; -> void Foo() final; This patch was automatically generated. The clang plugin can generate fixit hints, which are suggested edits when it is 100% sure it knows how to fix a problem. The hints from the clang plugin were applied to the source tree using the tool in https://codereview.chromium.org/598073004. BUG=417463 R=erg@chromium.org Committed: https://crrev.com/1fd71638c55cf30548b46c2b9fd7b3ff567a256f Cr-Commit-Position: refs/heads/master@{#300734}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+263 lines, -304 lines) Patch
M chrome/browser/profiles/avatar_menu.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/avatar_menu_actions_desktop.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/profiles/bookmark_model_loaded_observer.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service.h View 3 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/profiles/gaia_info_update_service_factory.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/profiles/host_zoom_map_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/incognito_mode_policy_handler.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.h View 2 chunks +47 lines, -52 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_io_data.h View 1 chunk +15 lines, -19 lines 0 comments Download
M chrome/browser/profiles/profile.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_avatar_downloader.h View 1 chunk +2 lines, -2 lines 1 comment Download
M chrome/browser/profiles/profile_avatar_icon_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/profiles/profile_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/profile_destroyer.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_downloader.h View 2 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/profiles/profile_impl.h View 2 chunks +48 lines, -53 lines 0 comments Download
M chrome/browser/profiles/profile_impl_io_data.h View 2 chunks +16 lines, -20 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache.h View 2 chunks +22 lines, -31 lines 0 comments Download
M chrome/browser/profiles/profile_info_cache_unittest.h View 1 chunk +8 lines, -11 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_list_desktop_unittest.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_manager.h View 4 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/profiles/profile_manager_browsertest.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/profiles/profile_manager_unittest.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/profiles/profile_window.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/profiles/startup_task_runner_service.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profiles/startup_task_runner_service_factory.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
dcheng
6 years, 2 months ago (2014-10-21 21:10:48 UTC) #1
Elliot Glaysher
lgtm https://codereview.chromium.org/654223009/diff/1/chrome/browser/profiles/profile_avatar_downloader.h File chrome/browser/profiles/profile_avatar_downloader.h (right): https://codereview.chromium.org/654223009/diff/1/chrome/browser/profiles/profile_avatar_downloader.h#newcode17 chrome/browser/profiles/profile_avatar_downloader.h:17: ~ProfileAvatarDownloader() override; Man its going to take some ...
6 years, 2 months ago (2014-10-22 17:52:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654223009/1
6 years, 2 months ago (2014-10-22 17:59:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel/builds/1662)
6 years, 2 months ago (2014-10-22 18:39:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/654223009/1
6 years, 2 months ago (2014-10-22 18:42:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 20:15:01 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 20:16:20 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fd71638c55cf30548b46c2b9fd7b3ff567a256f
Cr-Commit-Position: refs/heads/master@{#300734}

Powered by Google App Engine
This is Rietveld 408576698