chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h - Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/bookmark_model_loaded_observer.h ('k') | chrome/browser/profiles/gaia_info_update_service.h » ('j') | chrome/browser/profiles/profile_avatar_downloader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h

diff --git a/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h b/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h

index 3120ae57fe8bd7b1d4d17d8f41f3641003695f2f..f20e834850d0fa43ca2d830e815e23eafdee81ac 100644

--- a/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h

+++ b/chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.h

@@ -18,7 +18,7 @@ void AddProfilesExtraParts(ChromeBrowserMainParts* main_parts);

class ChromeBrowserMainExtraPartsProfiles : public ChromeBrowserMainExtraParts {

public:

ChromeBrowserMainExtraPartsProfiles();

- virtual ~ChromeBrowserMainExtraPartsProfiles();

+ ~ChromeBrowserMainExtraPartsProfiles() override;

// Instantiates all chrome KeyedService factories, which is

// especially important for services that should be created at profile

@@ -26,7 +26,7 @@ class ChromeBrowserMainExtraPartsProfiles : public ChromeBrowserMainExtraParts {

static void EnsureBrowserContextKeyedServiceFactoriesBuilt();

// Overridden from ChromeBrowserMainExtraParts:

- virtual void PreProfileInit() override;

+ void PreProfileInit() override;

private:

DISALLOW_COPY_AND_ASSIGN(ChromeBrowserMainExtraPartsProfiles);