chrome/browser/profiles/avatar_menu_actions_desktop.h - Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/avatar_menu_actions_desktop.h

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/profiles/avatar_menu.h ('k') | chrome/browser/profiles/bookmark_model_loaded_observer.h » ('j') | chrome/browser/profiles/profile_avatar_downloader.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/avatar_menu_actions_desktop.h

diff --git a/chrome/browser/profiles/avatar_menu_actions_desktop.h b/chrome/browser/profiles/avatar_menu_actions_desktop.h

index 031923fdd4336cff1a948af487a632e73be9c25b..a015c37fed70e3d512c4547629d0f08e87e054aa 100644

--- a/chrome/browser/profiles/avatar_menu_actions_desktop.h

+++ b/chrome/browser/profiles/avatar_menu_actions_desktop.h

@@ -16,14 +16,14 @@ class Profile;

class AvatarMenuActionsDesktop : public AvatarMenuActions {

public:

AvatarMenuActionsDesktop();

- virtual ~AvatarMenuActionsDesktop();

+ ~AvatarMenuActionsDesktop() override;

// AvatarMenuActions overrides:

- virtual void AddNewProfile(ProfileMetrics::ProfileAdd type) override;

- virtual void EditProfile(Profile* profile, size_t index) override;

- virtual bool ShouldShowAddNewProfileLink() const override;

- virtual bool ShouldShowEditProfileLink() const override;

- virtual void ActiveBrowserChanged(Browser* browser) override;

+ void AddNewProfile(ProfileMetrics::ProfileAdd type) override;

+ void EditProfile(Profile* profile, size_t index) override;

+ bool ShouldShowAddNewProfileLink() const override;

+ bool ShouldShowEditProfileLink() const override;

+ void ActiveBrowserChanged(Browser* browser) override;

private:

// Browser in which this avatar menu resides. Weak.