chrome/browser/profiles/profile_window.cc - Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/profiles/profile_window.cc

Issue 654223009: Standardize usage of virtual/override/final in chrome/browser/profiles/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/profiles/profile_avatar_downloader.h ('K') | « chrome/browser/profiles/profile_manager_unittest.cc ('k') | chrome/browser/profiles/startup_task_runner_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/profiles/profile_window.cc

diff --git a/chrome/browser/profiles/profile_window.cc b/chrome/browser/profiles/profile_window.cc

index f2d44d4358c6eed2c4c1fb5a2d8560185e98537d..ea5bb928b2cb09a639d1394052aac1bb7b18a5d4 100644

--- a/chrome/browser/profiles/profile_window.cc

+++ b/chrome/browser/profiles/profile_window.cc

@@ -57,12 +57,11 @@ class BrowserAddedForProfileObserver : public chrome::BrowserListObserver {

DCHECK(!callback_.is_null());

BrowserList::AddObserver(this);

}

- virtual ~BrowserAddedForProfileObserver() {

- }

+ ~BrowserAddedForProfileObserver() override {}

private:

// Overridden from BrowserListObserver:

- virtual void OnBrowserAdded(Browser* browser) override {

+ void OnBrowserAdded(Browser* browser) override {

if (browser->profile() == profile_) {

BrowserList::RemoveObserver(this);

callback_.Run(profile_, Profile::CREATE_STATUS_INITIALIZED);