Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653563004: NULL -> nullptr under athena/ (Closed)

Created:
6 years, 2 months ago by oshima
Modified:
6 years, 2 months ago
Reviewers:
Jun Mukai
CC:
chromium-reviews, extensions-reviews_chromium.org, jam, dcheng, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Project:
chromium
Visibility:
Public.

Description

NULL -> nullptr under athena/ BUG=None Committed: https://crrev.com/c04d30224253780f35d5721c238b24549ddebede Cr-Commit-Position: refs/heads/master@{#300978}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -255 lines) Patch
M athena/activity/activity_factory.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M athena/activity/activity_manager_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/activity/activity_manager_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M athena/activity/public/activity.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/activity/public/activity_view_model.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/content/app_activity.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M athena/content/app_activity_browsertest.cc View 8 chunks +13 lines, -13 lines 0 comments Download
M athena/content/app_activity_proxy.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/content/app_activity_registry.h View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/content/app_activity_registry.cc View 4 chunks +7 lines, -6 lines 0 comments Download
M athena/content/app_activity_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M athena/content/app_registry_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/content/chrome/web_activity_helpers_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/content_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/content_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/shell/dialogs.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/content/web_activity.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M athena/content/web_contents_view_delegate_factory_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/env/athena_env_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M athena/extensions/athena_app_delegate_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/extensions/chrome/app_list_controller_delegate_athena.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/chrome/athena_chrome_app_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/chrome/athena_extension_install_ui.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/extensions/chrome/extensions_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/extension_app_model_builder.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/extensions_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/extensions/shell/athena_shell_app_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/shell/extensions_delegate_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M athena/extensions/shell/shell_search_controller_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/extensions/shell/url_search_provider.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M athena/extensions/test/test_extensions_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/home/athena_start_page_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/home/home_card_impl.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M athena/home/home_card_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/input/accelerator_manager_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M athena/input/input_manager_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/main/athena_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/main/athena_views_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/resource_manager/memory_pressure_notifier_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/resource_manager/resource_manager_impl.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M athena/screen/modal_window_controller.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M athena/screen/modal_window_controller_unittest.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M athena/screen/screen_manager_impl.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M athena/screen/screen_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M athena/screen_lock/screen_lock_manager_base.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M athena/screen_lock/shell/shell_screen_lock_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/system/background_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/system/network_selector.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M athena/system/system_ui_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M athena/test/base/activity_lifetime_tracker.h View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/test/base/activity_lifetime_tracker.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M athena/test/base/athena_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/test/base/sample_activity.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M athena/util/fill_layout_manager_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M athena/virtual_keyboard/virtual_keyboard_manager_impl.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M athena/wm/bezel_controller.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M athena/wm/split_view_controller.h View 3 chunks +5 lines, -4 lines 0 comments Download
M athena/wm/split_view_controller.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M athena/wm/split_view_controller_unittest.cc View 12 chunks +19 lines, -16 lines 0 comments Download
M athena/wm/title_drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M athena/wm/window_list_provider_impl_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M athena/wm/window_manager_impl.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M athena/wm/window_manager_unittest.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M athena/wm/window_overview_mode.h View 1 chunk +3 lines, -2 lines 0 comments Download
M athena/wm/window_overview_mode.cc View 10 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
oshima
6 years, 2 months ago (2014-10-23 18:05:47 UTC) #3
Jun Mukai
lgtm Please also send a PSA to athena team.
6 years, 2 months ago (2014-10-23 18:19:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653563004/20001
6 years, 2 months ago (2014-10-23 20:55:13 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-23 23:31:17 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 23:31:53 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c04d30224253780f35d5721c238b24549ddebede
Cr-Commit-Position: refs/heads/master@{#300978}

Powered by Google App Engine
This is Rietveld 408576698