Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: athena/activity/activity_manager_unittest.cc

Issue 653563004: NULL -> nullptr under athena/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « athena/activity/activity_manager_impl.cc ('k') | athena/activity/public/activity.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /// Copyright 2014 The Chromium Authors. All rights reserved. 1 /// Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/activity/activity_manager_impl.h" 5 #include "athena/activity/activity_manager_impl.h"
6 6
7 #include "athena/activity/public/activity.h" 7 #include "athena/activity/public/activity.h"
8 #include "athena/activity/public/activity_factory.h" 8 #include "athena/activity/public/activity_factory.h"
9 #include "athena/test/base/athena_test_base.h" 9 #include "athena/test/base/athena_test_base.h"
10 #include "athena/test/base/test_windows.h" 10 #include "athena/test/base/test_windows.h"
11 #include "ui/aura/window.h" 11 #include "ui/aura/window.h"
12 12
13 namespace athena { 13 namespace athena {
14 14
15 typedef test::AthenaTestBase ActivityManagerTest; 15 typedef test::AthenaTestBase ActivityManagerTest;
16 16
17 TEST_F(ActivityManagerTest, Basic) { 17 TEST_F(ActivityManagerTest, Basic) {
18 ActivityManagerImpl* activity_manager = 18 ActivityManagerImpl* activity_manager =
19 static_cast<ActivityManagerImpl*>(ActivityManager::Get()); 19 static_cast<ActivityManagerImpl*>(ActivityManager::Get());
20 ActivityFactory* factory = ActivityFactory::Get(); 20 ActivityFactory* factory = ActivityFactory::Get();
21 21
22 Activity* activity1 = 22 Activity* activity1 =
23 factory->CreateWebActivity(NULL, base::string16(), GURL()); 23 factory->CreateWebActivity(nullptr, base::string16(), GURL());
24 EXPECT_EQ(1, activity_manager->num_activities()); 24 EXPECT_EQ(1, activity_manager->num_activities());
25 25
26 // Activity is not visible when created. 26 // Activity is not visible when created.
27 EXPECT_FALSE(activity1->GetWindow()->TargetVisibility()); 27 EXPECT_FALSE(activity1->GetWindow()->TargetVisibility());
28 Activity::Show(activity1); 28 Activity::Show(activity1);
29 EXPECT_TRUE(activity1->GetWindow()->TargetVisibility()); 29 EXPECT_TRUE(activity1->GetWindow()->TargetVisibility());
30 30
31 Activity* activity2 = 31 Activity* activity2 =
32 factory->CreateWebActivity(NULL, base::string16(), GURL()); 32 factory->CreateWebActivity(nullptr, base::string16(), GURL());
33 EXPECT_EQ(2, activity_manager->num_activities()); 33 EXPECT_EQ(2, activity_manager->num_activities());
34 34
35 Activity::Delete(activity1); 35 Activity::Delete(activity1);
36 EXPECT_EQ(1, activity_manager->num_activities()); 36 EXPECT_EQ(1, activity_manager->num_activities());
37 37
38 // Deleting the activity's window should delete the activity itself. 38 // Deleting the activity's window should delete the activity itself.
39 delete activity2->GetWindow(); 39 delete activity2->GetWindow();
40 EXPECT_EQ(0, activity_manager->num_activities()); 40 EXPECT_EQ(0, activity_manager->num_activities());
41 } 41 }
42 42
43 TEST_F(ActivityManagerTest, GetActivityForWindow) { 43 TEST_F(ActivityManagerTest, GetActivityForWindow) {
44 ActivityManager* manager = ActivityManager::Get(); 44 ActivityManager* manager = ActivityManager::Get();
45 ActivityFactory* factory = ActivityFactory::Get(); 45 ActivityFactory* factory = ActivityFactory::Get();
46 46
47 Activity* activity1 = 47 Activity* activity1 =
48 factory->CreateWebActivity(NULL, base::string16(), GURL()); 48 factory->CreateWebActivity(nullptr, base::string16(), GURL());
49 Activity* activity2 = 49 Activity* activity2 =
50 factory->CreateWebActivity(NULL, base::string16(), GURL()); 50 factory->CreateWebActivity(nullptr, base::string16(), GURL());
51 51
52 EXPECT_EQ(activity1, manager->GetActivityForWindow(activity1->GetWindow())); 52 EXPECT_EQ(activity1, manager->GetActivityForWindow(activity1->GetWindow()));
53 EXPECT_EQ(activity2, manager->GetActivityForWindow(activity2->GetWindow())); 53 EXPECT_EQ(activity2, manager->GetActivityForWindow(activity2->GetWindow()));
54 54
55 EXPECT_EQ(NULL, manager->GetActivityForWindow(NULL)); 55 EXPECT_EQ(nullptr, manager->GetActivityForWindow(nullptr));
56 56
57 scoped_ptr<aura::Window> window = test::CreateNormalWindow(NULL, NULL); 57 scoped_ptr<aura::Window> window = test::CreateNormalWindow(nullptr, nullptr);
58 EXPECT_EQ(NULL, manager->GetActivityForWindow(window.get())); 58 EXPECT_EQ(nullptr, manager->GetActivityForWindow(window.get()));
59 } 59 }
60 60
61 } // namespace athena 61 } // namespace athena
OLDNEW
« no previous file with comments | « athena/activity/activity_manager_impl.cc ('k') | athena/activity/public/activity.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698