Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: athena/activity/activity_manager_impl.cc

Issue 653563004: NULL -> nullptr under athena/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « athena/activity/activity_factory.cc ('k') | athena/activity/activity_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/activity/activity_manager_impl.h" 5 #include "athena/activity/activity_manager_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "athena/activity/activity_widget_delegate.h" 9 #include "athena/activity/activity_widget_delegate.h"
10 #include "athena/activity/public/activity.h" 10 #include "athena/activity/public/activity.h"
11 #include "athena/activity/public/activity_manager_observer.h" 11 #include "athena/activity/public/activity_manager_observer.h"
12 #include "athena/activity/public/activity_view_model.h" 12 #include "athena/activity/public/activity_view_model.h"
13 #include "base/logging.h" 13 #include "base/logging.h"
14 #include "base/observer_list.h" 14 #include "base/observer_list.h"
15 #include "ui/views/widget/widget.h" 15 #include "ui/views/widget/widget.h"
16 16
17 namespace athena { 17 namespace athena {
18 18
19 namespace { 19 namespace {
20 20
21 ActivityManager* instance = NULL; 21 ActivityManager* instance = nullptr;
22 22
23 views::Widget* CreateWidget(Activity* activity) { 23 views::Widget* CreateWidget(Activity* activity) {
24 ActivityViewModel* view_model = activity->GetActivityViewModel(); 24 ActivityViewModel* view_model = activity->GetActivityViewModel();
25 views::Widget* widget = view_model->CreateWidget(); 25 views::Widget* widget = view_model->CreateWidget();
26 if (widget) 26 if (widget)
27 return widget; 27 return widget;
28 widget = new views::Widget; 28 widget = new views::Widget;
29 views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW); 29 views::Widget::InitParams params(views::Widget::InitParams::TYPE_WINDOW);
30 params.delegate = new ActivityWidgetDelegate(view_model); 30 params.delegate = new ActivityWidgetDelegate(view_model);
31 widget->Init(params); 31 widget->Init(params);
(...skipping 12 matching lines...) Expand all
44 ActivityManagerImpl::ActivityManagerImpl() { 44 ActivityManagerImpl::ActivityManagerImpl() {
45 CHECK(!instance); 45 CHECK(!instance);
46 instance = this; 46 instance = this;
47 } 47 }
48 48
49 ActivityManagerImpl::~ActivityManagerImpl() { 49 ActivityManagerImpl::~ActivityManagerImpl() {
50 while (!activities_.empty()) 50 while (!activities_.empty())
51 Activity::Delete(activities_.front()); 51 Activity::Delete(activities_.front());
52 52
53 CHECK_EQ(this, instance); 53 CHECK_EQ(this, instance);
54 instance = NULL; 54 instance = nullptr;
55 } 55 }
56 56
57 void ActivityManagerImpl::AddActivity(Activity* activity) { 57 void ActivityManagerImpl::AddActivity(Activity* activity) {
58 CHECK(activities_.end() == 58 CHECK(activities_.end() ==
59 std::find(activities_.begin(), activities_.end(), activity)); 59 std::find(activities_.begin(), activities_.end(), activity));
60 activities_.push_back(activity); 60 activities_.push_back(activity);
61 views::Widget* widget = CreateWidget(activity); 61 views::Widget* widget = CreateWidget(activity);
62 widget->AddObserver(this); 62 widget->AddObserver(this);
63 FOR_EACH_OBSERVER(ActivityManagerObserver, 63 FOR_EACH_OBSERVER(ActivityManagerObserver,
64 observers_, 64 observers_,
(...skipping 23 matching lines...) Expand all
88 Activity* ActivityManagerImpl::GetActivityForWindow(aura::Window* window) { 88 Activity* ActivityManagerImpl::GetActivityForWindow(aura::Window* window) {
89 struct Matcher { 89 struct Matcher {
90 Matcher(aura::Window* w) : window(w) {} 90 Matcher(aura::Window* w) : window(w) {}
91 bool operator()(Activity* activity) { 91 bool operator()(Activity* activity) {
92 return activity->GetWindow() == window; 92 return activity->GetWindow() == window;
93 } 93 }
94 aura::Window* window; 94 aura::Window* window;
95 }; 95 };
96 std::vector<Activity*>::iterator iter = 96 std::vector<Activity*>::iterator iter =
97 std::find_if(activities_.begin(), activities_.end(), Matcher(window)); 97 std::find_if(activities_.begin(), activities_.end(), Matcher(window));
98 return iter != activities_.end() ? *iter : NULL; 98 return iter != activities_.end() ? *iter : nullptr;
99 } 99 }
100 100
101 void ActivityManagerImpl::AddObserver(ActivityManagerObserver* observer) { 101 void ActivityManagerImpl::AddObserver(ActivityManagerObserver* observer) {
102 observers_.AddObserver(observer); 102 observers_.AddObserver(observer);
103 } 103 }
104 104
105 void ActivityManagerImpl::RemoveObserver(ActivityManagerObserver* observer) { 105 void ActivityManagerImpl::RemoveObserver(ActivityManagerObserver* observer) {
106 observers_.RemoveObserver(observer); 106 observers_.RemoveObserver(observer);
107 } 107 }
108 108
(...skipping 16 matching lines...) Expand all
125 return instance; 125 return instance;
126 } 126 }
127 127
128 void ActivityManager::Shutdown() { 128 void ActivityManager::Shutdown() {
129 CHECK(instance); 129 CHECK(instance);
130 delete instance; 130 delete instance;
131 } 131 }
132 132
133 133
134 } // namespace athena 134 } // namespace athena
OLDNEW
« no previous file with comments | « athena/activity/activity_factory.cc ('k') | athena/activity/activity_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698