Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: athena/content/app_activity_registry.cc

Issue 653563004: NULL -> nullptr under athena/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « athena/content/app_activity_registry.h ('k') | athena/content/app_activity_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "athena/content/app_activity_registry.h" 5 #include "athena/content/app_activity_registry.h"
6 6
7 #include "athena/activity/public/activity_manager.h" 7 #include "athena/activity/public/activity_manager.h"
8 #include "athena/content/app_activity.h" 8 #include "athena/content/app_activity.h"
9 #include "athena/content/app_activity_proxy.h" 9 #include "athena/content/app_activity_proxy.h"
10 #include "athena/content/public/app_registry.h" 10 #include "athena/content/public/app_registry.h"
11 #include "athena/extensions/public/extensions_delegate.h" 11 #include "athena/extensions/public/extensions_delegate.h"
12 #include "athena/resource_manager/public/resource_manager.h" 12 #include "athena/resource_manager/public/resource_manager.h"
13 #include "athena/wm/public/window_list_provider.h" 13 #include "athena/wm/public/window_list_provider.h"
14 #include "athena/wm/public/window_manager.h" 14 #include "athena/wm/public/window_manager.h"
15 #include "base/bind.h" 15 #include "base/bind.h"
16 #include "base/location.h" 16 #include "base/location.h"
17 #include "base/single_thread_task_runner.h" 17 #include "base/single_thread_task_runner.h"
18 #include "base/thread_task_runner_handle.h" 18 #include "base/thread_task_runner_handle.h"
19 #include "ui/aura/window.h" 19 #include "ui/aura/window.h"
20 #include "ui/views/view.h" 20 #include "ui/views/view.h"
21 #include "ui/views/widget/widget.h" 21 #include "ui/views/widget/widget.h"
22 22
23 namespace athena { 23 namespace athena {
24 24
25 AppActivityRegistry::AppActivityRegistry( 25 AppActivityRegistry::AppActivityRegistry(
26 const std::string& app_id, 26 const std::string& app_id,
27 content::BrowserContext* browser_context) : 27 content::BrowserContext* browser_context)
28 app_id_(app_id), 28 : app_id_(app_id),
29 browser_context_(browser_context), 29 browser_context_(browser_context),
30 unloaded_activity_proxy_(NULL) {} 30 unloaded_activity_proxy_(nullptr) {
31 }
31 32
32 AppActivityRegistry::~AppActivityRegistry() { 33 AppActivityRegistry::~AppActivityRegistry() {
33 CHECK(activity_list_.empty()); 34 CHECK(activity_list_.empty());
34 if (unloaded_activity_proxy_) 35 if (unloaded_activity_proxy_)
35 ActivityManager::Get()->RemoveActivity(unloaded_activity_proxy_); 36 ActivityManager::Get()->RemoveActivity(unloaded_activity_proxy_);
36 DCHECK(!unloaded_activity_proxy_); 37 DCHECK(!unloaded_activity_proxy_);
37 } 38 }
38 39
39 void AppActivityRegistry::RegisterAppActivity(AppActivity* app_activity) { 40 void AppActivityRegistry::RegisterAppActivity(AppActivity* app_activity) {
40 // The same window should never be added twice. 41 // The same window should never be added twice.
(...skipping 14 matching lines...) Expand all
55 // When the last window gets destroyed and there is no proxy to restart, we 56 // When the last window gets destroyed and there is no proxy to restart, we
56 // delete ourselves. 57 // delete ourselves.
57 if (activity_list_.empty() && !unloaded_activity_proxy_) { 58 if (activity_list_.empty() && !unloaded_activity_proxy_) {
58 AppRegistry::Get()->RemoveAppActivityRegistry(this); 59 AppRegistry::Get()->RemoveAppActivityRegistry(this);
59 // after this call this object should be gone. 60 // after this call this object should be gone.
60 } 61 }
61 } 62 }
62 63
63 AppActivity* AppActivityRegistry::GetAppActivityAt(size_t index) { 64 AppActivity* AppActivityRegistry::GetAppActivityAt(size_t index) {
64 if (index >= activity_list_.size()) 65 if (index >= activity_list_.size())
65 return NULL; 66 return nullptr;
66 return activity_list_[index]; 67 return activity_list_[index];
67 } 68 }
68 69
69 void AppActivityRegistry::Unload() { 70 void AppActivityRegistry::Unload() {
70 CHECK(!unloaded_activity_proxy_); 71 CHECK(!unloaded_activity_proxy_);
71 DCHECK(!activity_list_.empty()); 72 DCHECK(!activity_list_.empty());
72 // In order to allow an entire application to unload we require that all of 73 // In order to allow an entire application to unload we require that all of
73 // its activities are marked as unloaded. 74 // its activities are marked as unloaded.
74 for (std::vector<AppActivity*>::iterator it = activity_list_.begin(); 75 for (std::vector<AppActivity*>::iterator it = activity_list_.begin();
75 it != activity_list_.end(); ++it) { 76 it != activity_list_.end(); ++it) {
(...skipping 11 matching lines...) Expand all
87 // several activities will be closed / started. That can then cause a crash. 88 // several activities will be closed / started. That can then cause a crash.
88 // We postpone therefore the activity destruction till after the observer is 89 // We postpone therefore the activity destruction till after the observer is
89 // done. 90 // done.
90 base::ThreadTaskRunnerHandle::Get()->PostTask( 91 base::ThreadTaskRunnerHandle::Get()->PostTask(
91 FROM_HERE, 92 FROM_HERE,
92 base::Bind(&AppActivityRegistry::DelayedUnload, base::Unretained(this))); 93 base::Bind(&AppActivityRegistry::DelayedUnload, base::Unretained(this)));
93 } 94 }
94 95
95 void AppActivityRegistry::ProxyDestroyed(AppActivityProxy* proxy) { 96 void AppActivityRegistry::ProxyDestroyed(AppActivityProxy* proxy) {
96 DCHECK_EQ(unloaded_activity_proxy_, proxy); 97 DCHECK_EQ(unloaded_activity_proxy_, proxy);
97 unloaded_activity_proxy_ = NULL; 98 unloaded_activity_proxy_ = nullptr;
98 if (activity_list_.empty()) { 99 if (activity_list_.empty()) {
99 AppRegistry::Get()->RemoveAppActivityRegistry(this); 100 AppRegistry::Get()->RemoveAppActivityRegistry(this);
100 // |This| is gone now. 101 // |This| is gone now.
101 } 102 }
102 } 103 }
103 104
104 void AppActivityRegistry::RestartApplication(AppActivityProxy* proxy) { 105 void AppActivityRegistry::RestartApplication(AppActivityProxy* proxy) {
105 DCHECK_EQ(unloaded_activity_proxy_, proxy); 106 DCHECK_EQ(unloaded_activity_proxy_, proxy);
106 // Restart the application. Note that the first created app window will make 107 // Restart the application. Note that the first created app window will make
107 // sure that the proxy gets deleted - after - the new activity got moved 108 // sure that the proxy gets deleted - after - the new activity got moved
(...skipping 18 matching lines...) Expand all
126 for (aura::Window::Windows::const_iterator child_iterator = children.begin(); 127 for (aura::Window::Windows::const_iterator child_iterator = children.begin();
127 child_iterator != children.end(); ++child_iterator) { 128 child_iterator != children.end(); ++child_iterator) {
128 for (std::vector<AppActivity*>::iterator app_iterator = 129 for (std::vector<AppActivity*>::iterator app_iterator =
129 activity_list_.begin(); 130 activity_list_.begin();
130 app_iterator != activity_list_.end(); ++app_iterator) { 131 app_iterator != activity_list_.end(); ++app_iterator) {
131 if (*child_iterator == (*app_iterator)->GetWindow()) 132 if (*child_iterator == (*app_iterator)->GetWindow())
132 return *app_iterator; 133 return *app_iterator;
133 } 134 }
134 } 135 }
135 NOTREACHED() << "The application does not get tracked by the mru list"; 136 NOTREACHED() << "The application does not get tracked by the mru list";
136 return NULL; 137 return nullptr;
137 } 138 }
138 139
139 } // namespace athena 140 } // namespace athena
OLDNEW
« no previous file with comments | « athena/content/app_activity_registry.h ('k') | athena/content/app_activity_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698