Test monotonicity of expression typings.

Test monotonicity of expression typings.

R=rossberg@chromium.org
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=24693

[rossberg, 2014-10-15 12:37:27]

https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):

https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h#n...
src/compiler/js-operator.h:12: #define SHARED_SIMPLE_BINOP_LIST(V)              
        \
Please do not expose this just for the sake of a test. It's okay to repeat the
list in the test.

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h
File test/cctest/test-types.h (right):

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
test/cctest/test-types.h:28: #ifndef V8_TEST_CCTEST_TEST_TYPES_H_
Please name this file differently, so that it is not confused with the .cc file
of the same name.

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
test/cctest/test-types.h:38: class Types {
Did anything change in here, other than moving it?

[neis1, 2014-10-15 13:56:48]

https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h
File src/compiler/js-operator.h (right):

https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h#n...
src/compiler/js-operator.h:12: #define SHARED_SIMPLE_BINOP_LIST(V)              
        \
On 2014/10/15 12:37:27, rossberg wrote:
> Please do not expose this just for the sake of a test. It's okay to repeat the
> list in the test.

Done.

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h
File test/cctest/test-types.h (right):

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
test/cctest/test-types.h:28: #ifndef V8_TEST_CCTEST_TEST_TYPES_H_
On 2014/10/15 12:37:27, rossberg wrote:
> Please name this file differently, so that it is not confused with the .cc
file
> of the same name.

Done.

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
test/cctest/test-types.h:28: #ifndef V8_TEST_CCTEST_TEST_TYPES_H_
On 2014/10/15 12:37:27, rossberg wrote:
> Please name this file differently, so that it is not confused with the .cc
file
> of the same name.

Done.

https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
test/cctest/test-types.h:38: class Types {
On 2014/10/15 12:37:27, rossberg wrote:
> Did anything change in here, other than moving it?

No.

[neis1, 2014-10-15 14:00:36]

Dammit, something went wrong: the second patch set includes changes from a
different CL.

The actual changes are minimal: I move SHARED_SIMPLE_BINOP_LIST back to where it
was and copied it into my test file.  And renamed test-types.h to types.h (in
cctest/).

On 2014/10/15 13:56:48, neis1 wrote:
> https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h
> File src/compiler/js-operator.h (right):
> 
>
https://codereview.chromium.org/653093002/diff/1/src/compiler/js-operator.h#n...
> src/compiler/js-operator.h:12: #define SHARED_SIMPLE_BINOP_LIST(V)            
 
>         \
> On 2014/10/15 12:37:27, rossberg wrote:
> > Please do not expose this just for the sake of a test. It's okay to repeat
the
> > list in the test.
> 
> Done.
> 
> https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h
> File test/cctest/test-types.h (right):
> 
>
https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
> test/cctest/test-types.h:28: #ifndef V8_TEST_CCTEST_TEST_TYPES_H_
> On 2014/10/15 12:37:27, rossberg wrote:
> > Please name this file differently, so that it is not confused with the .cc
> file
> > of the same name.
> 
> Done.
> 
>
https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
> test/cctest/test-types.h:28: #ifndef V8_TEST_CCTEST_TEST_TYPES_H_
> On 2014/10/15 12:37:27, rossberg wrote:
> > Please name this file differently, so that it is not confused with the .cc
> file
> > of the same name.
> 
> Done.
> 
>
https://codereview.chromium.org/653093002/diff/1/test/cctest/test-types.h#new...
> test/cctest/test-types.h:38: class Types {
> On 2014/10/15 12:37:27, rossberg wrote:
> > Did anything change in here, other than moving it?
> 
> No.

[rossberg, 2014-10-17 10:54:03]

LGTM, except:

> renamed test-types.h to types.h (in cctest/).

Can we have a more specific name, e.g., type-fuzzer.h?

[neis, 2014-10-17 11:46:18]

Committed patchset #2 (id:20001) manually as 24693 (presubmit successful).