Removing the OVERRIDE and FINAL macros from wtf/Compiler.h

Removing the OVERRIDE and FINAL macros from wtf/Compiler.h

This change will remove OVERRIDE and FINAL from WebKit folder, as per
c++11 standard only allowed entries are override and final.

BUG=417463

[MRV, 2014-10-13 13:23:16]

mohan.reddy@samsung.com changed reviewers:
+ tkent@chromium.org

[MRV, 2014-10-13 13:23:17]

PTAL

[MRV, 2014-10-13 13:24:21]

On 2014/10/13 13:23:17, MRV wrote:
> PTAL

This Patch has to get landed after
https://codereview.chromium.org/652693002/

[MRV, 2014-10-13 13:31:01]

On 2014/10/13 13:24:21, MRV wrote:
> On 2014/10/13 13:23:17, MRV wrote:
> > PTAL
> 
> This Patch has to get landed after
> https://codereview.chromium.org/652693002/

Mr. Mike, currently Mr.tkent is looking as unavailable, Could you please add
reviewer for this file.

[Mike West, 2014-10-13 13:35:20]

mkwst@chromium.org changed reviewers:
+ erik.corry@gmail.com, mikhail.pozdnyakov@intel.com, mkwst@chromium.org,
thakis@chromium.org

[Mike West, 2014-10-13 13:35:21]

Nico, Mikhail, or Eric should be able to take a look.

[MRV, 2014-10-13 13:43:31]

On 2014/10/13 13:35:21, Mike West wrote:
> Nico, Mikhail, or Eric should be able to take a look.

Thanks Mr.Mike.
@Mr. Nico or Mr.Mikhail or Mr. Eric, PTAL.

[Erik Corry, 2014-10-13 13:51:22]

On 2014/10/13 13:43:31, MRV wrote:
> On 2014/10/13 13:35:21, Mike West wrote:
> > Nico, Mikhail, or Eric should be able to take a look.
> 
> Thanks Mr.Mike.
> @Mr. Nico or Mr.Mikhail or Mr. Eric, PTAL.

LGTM

[MRV, 2014-10-13 13:54:28]

On 2014/10/13 13:51:22, Erik Corry wrote:
> On 2014/10/13 13:43:31, MRV wrote:
> > On 2014/10/13 13:35:21, Mike West wrote:
> > > Nico, Mikhail, or Eric should be able to take a look.
> > 
> > Thanks Mr.Mike.
> > @Mr. Nico or Mr.Mikhail or Mr. Eric, PTAL.
> 
> LGTM

Thanks Mr. Erik.

[Mikhail, 2014-10-13 13:55:44]

lgtm

[Nico, 2014-10-13 15:04:06]

lgtm

[MRV, 2014-10-13 16:59:55]

On 2014/10/13 15:04:06, Nico (away until Oct 27) wrote:
> lgtm

Thanks mr. Nico, mr.mikhail and mr.eric for review.

[MRV, 2014-10-13 17:00:44]

The CQ bit was checked by mohan.reddy@samsung.com

[commit-bot: I haz the power, 2014-10-13 17:01:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652663004/1

[commit-bot: I haz the power, 2014-10-13 18:39:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-13 18:39:04]

Failed to apply patch for Source/wtf/Compiler.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/wtf/Compiler.h
  Hunk #4 FAILED at 189.
  1 out of 4 hunks FAILED -- saving rejects to file Source/wtf/Compiler.h.rej

Patch:       Source/wtf/Compiler.h
Index: Source/wtf/Compiler.h
diff --git a/Source/wtf/Compiler.h b/Source/wtf/Compiler.h
index
f0528d0dc2c485b101c7b7d95a06e76cd9e9904a..77bd54425286df6e803da60e45c70c27c7631acc
100644
--- a/Source/wtf/Compiler.h
+++ b/Source/wtf/Compiler.h
@@ -55,7 +55,6 @@
 #define WTF_COMPILER_SUPPORTS_BLOCKS __has_feature(blocks)
 #define WTF_COMPILER_SUPPORTS_C_STATIC_ASSERT __has_extension(c_static_assert)
 #define WTF_COMPILER_SUPPORTS_CXX_STATIC_ASSERT
__has_extension(cxx_static_assert)
-#define WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL
__has_extension(cxx_override_control)
 #define WTF_COMPILER_SUPPORTS_HAS_TRIVIAL_DESTRUCTOR
__has_extension(has_trivial_destructor)
 #define WTF_COMPILER_SUPPORTS_CXX_STRONG_ENUMS
__has_extension(cxx_strong_enums)
 
@@ -73,8 +72,6 @@
 #if COMPILER(CLANG)
 /* Keep strong enums turned off when building with clang-cl: We cannot yet
build all of Blink without fallback to cl.exe, and strong enums are exposed at
ABI boundaries. */
 #undef WTF_COMPILER_SUPPORTS_CXX_STRONG_ENUMS
-#else
-#define WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL 1
 #endif
 
 #endif
@@ -111,9 +108,6 @@
 /* Strong enums should work from gcc 4.4, but doesn't seem to support some
operators */
 #define WTF_COMPILER_SUPPORTS_CXX_STRONG_ENUMS 1
 #endif
-#if GCC_VERSION_AT_LEAST(4, 7, 0)
-#define WTF_COMPILER_SUPPORTS_CXX_OVERRIDE_CONTROL 1
-#endif
 #endif /* defined(__GXX_EXPERIMENTAL_CXX0X__) || (defined(__cplusplus) &&
__cplusplus >= 201103L) */
 #endif /* COMPILER(GCC) */
 
@@ -195,17 +189,6 @@
 #define ALLOW_UNUSED_LOCAL(x) false ? (void)x : (void)0
 
 
-/* OVERRIDE and FINAL */
-
-#if COMPILER_SUPPORTS(CXX_OVERRIDE_CONTROL)
-#define OVERRIDE override
-#define FINAL final
-#else
-#define OVERRIDE
-#define FINAL
-#endif
-
-
 /* WTF_DELETED_FUNCTION */
 
 #if COMPILER_SUPPORTS(CXX_DELETED_FUNCTIONS)

[commit-bot: I haz the power, 2014-10-13 18:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[MRV, 2014-10-14 03:06:03]

Almost similar patch is landed by Mr. dcheng, just before landing my patch.
https://codereview.chromium.org/648223003
https://codereview.chromium.org/650933002
Hence closing this review.