Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 648223003: Remove a few residual references to the old OVERRIDE and FINAL macros. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, mkwst+moarreviews_chromium.org
Project:
blink
Visibility:
Public.

Description

Remove a few residual references to the old OVERRIDE and FINAL macros. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183630

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -27 lines) Patch
M Source/wtf/Compiler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 chunk +2 lines, -2 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
dcheng
Just a few things I missed in the initial patch (https://codereview.chromium.org/650933002) to remove these macros.
6 years, 2 months ago (2014-10-13 17:13:13 UTC) #2
Julien - ping for review
LGTM for wtf/. The Tools/ part looks OK but I am not an OWNER. +Dirk ...
6 years, 2 months ago (2014-10-13 17:29:53 UTC) #4
dcheng
Tools/Scripts allows anyone to review (the OWNERS file is just *). If it looks OK ...
6 years, 2 months ago (2014-10-13 20:47:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/648223003/1
6 years, 2 months ago (2014-10-13 20:48:09 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-13 23:06:08 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 183630

Powered by Google App Engine
This is Rietveld 408576698