Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 650933002: Remove OVERRIDE and FINAL macros. (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
adamk
CC:
aandrey+blink_chromium.org, blink-reviews, blink-reviews-rendering, blink-reviews-wtf_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, Mikhail, mkwst+moarreviews_chromium.org, pdr+renderingwatchlist_chromium.org, rune+blink, zoltan1
Project:
blink
Visibility:
Public.

Description

Remove OVERRIDE and FINAL macros. All uses appear to have been removed from the codebase. BUG=417463 TBR=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183618

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M Source/wtf/Compiler.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcheng
Pretty easy review. I'll clean up some small uses of this in the Python cpp ...
6 years, 2 months ago (2014-10-13 17:00:07 UTC) #2
dcheng
Committed patchset #2 (id:100001) manually as 183618 (presubmit successful).
6 years, 2 months ago (2014-10-13 17:02:59 UTC) #3
adamk
6 years, 2 months ago (2014-10-14 20:52:04 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698