Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 652623003: Extensions: Split the constants from the extensions_common target into its own extensions_common_co… (Closed)

Created:
6 years, 2 months ago by Lei Zhang
Modified:
6 years, 2 months ago
Reviewers:
Yoyo Zhou
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Extensions: Split the constants from the extensions_common target into its own extensions_common_constants target. The extensions constants are used in too many places and very hard to get rid of. Making it into its own target so it can be included in all builds, even when extensions are not enabled. BUG=424746 Committed: https://crrev.com/cdced8a6809240a42b61875af5ff2c37b754ba07 Cr-Commit-Position: refs/heads/master@{#300335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -4 lines) Patch
M extensions/common/BUILD.gn View 3 chunks +15 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 3 chunks +17 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lei Zhang
6 years, 2 months ago (2014-10-18 00:06:04 UTC) #2
Lei Zhang
The new target will be used in chrome/chrome_common.gypi next week.
6 years, 2 months ago (2014-10-18 00:09:09 UTC) #3
Yoyo Zhou
LGTM
6 years, 2 months ago (2014-10-20 21:09:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/652623003/1
6 years, 2 months ago (2014-10-20 21:13:12 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-20 21:45:14 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 21:46:07 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cdced8a6809240a42b61875af5ff2c37b754ba07
Cr-Commit-Position: refs/heads/master@{#300335}

Powered by Google App Engine
This is Rietveld 408576698