Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: extensions/common/BUILD.gn

Issue 652623003: Extensions: Split the constants from the extensions_common target into its own extensions_common_co… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/extensions.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/BUILD.gn
diff --git a/extensions/common/BUILD.gn b/extensions/common/BUILD.gn
index e3fa36ea8b26f9d8b3b7c5a0391e9353cc17a858..dcc043b23fc6fdeb5d738e823ae9694a92fb9e03 100644
--- a/extensions/common/BUILD.gn
+++ b/extensions/common/BUILD.gn
@@ -11,6 +11,20 @@ mojom("mojo") {
]
}
+# GYP version: extensions/extensions.gyp:extensions_common_constants
+source_set("common_constants") {
+ sources = [
+ "constants.cc",
+ "constants.h",
+ ]
+
+ if (is_win) {
+ cflags = [
+ "/wd4267", # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
+ ]
+ }
+}
+
# GYP version: extensions/extensions.gyp:extensions_common
source_set("common") {
sources = [
@@ -29,8 +43,6 @@ source_set("common") {
"api/sockets/sockets_manifest_permission.h",
"common_manifest_handlers.cc",
"common_manifest_handlers.h",
- "constants.cc",
- "constants.h",
"csp_validator.cc",
"csp_validator.h",
"dom_action_types.h",
@@ -201,6 +213,7 @@ source_set("common") {
]
deps = [
+ ":common_constants",
":mojo",
# TODO(benwells): figure out what to do with the api target and
# api resources compiled into the chrome resource bundle.
« no previous file with comments | « no previous file | extensions/extensions.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698