Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(470)

Unified Diff: extensions/extensions.gyp

Issue 652623003: Extensions: Split the constants from the extensions_common target into its own extensions_common_co… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/extensions.gyp
diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp
index 2b866dfaf3ff43943351a5a13323bc31a1ab7625..21a1050cc1a85c4307cd6f09f13343ecf3bfb463 100644
--- a/extensions/extensions.gyp
+++ b/extensions/extensions.gyp
@@ -23,6 +23,22 @@
},
{
# GN version: //extensions/common
+ 'target_name': 'extensions_common_constants',
+ 'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ '<(INTERMEDIATE_DIR)',
+ ],
+ 'sources': [
+ # Note: sources list duplicated in GN build.
+ 'common/constants.cc',
+ 'common/constants.h',
+ ],
+ # Disable c4267 warnings until we fix size_t to int truncations.
+ 'msvs_disabled_warnings': [ 4267, ],
+ },
+ {
+ # GN version: //extensions/common
'target_name': 'extensions_common',
'type': 'static_library',
'dependencies': [
@@ -40,6 +56,7 @@
'../third_party/libxml/libxml.gyp:libxml',
'extensions_resources.gyp:extensions_resources',
'extensions_strings.gyp:extensions_strings',
+ 'extensions_common_constants',
'extensions_common_mojo',
],
'include_dirs': [
@@ -63,8 +80,6 @@
'common/api/sockets/sockets_manifest_permission.h',
'common/common_manifest_handlers.cc',
'common/common_manifest_handlers.h',
- 'common/constants.cc',
- 'common/constants.h',
'common/csp_validator.cc',
'common/csp_validator.h',
'common/dom_action_types.h',
« no previous file with comments | « extensions/common/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698