Extensions: Split the constants from the extensions_common target into its own extensions_common_co…

extensions/extensions.gyp

 # Copyright 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'chromium_code': 1,
   },
   'targets': [
     {
       # GN version: //extensions/common:mojo
       'target_name': 'extensions_common_mojo',
       # The type of this target must be none. This is so that resources can
       # depend upon this target for generating the js bindings files. Any
       # generated cpp files must be listed explicitly in extensions_common
       'type': 'none',
       'includes': [
         '../mojo/public/tools/bindings/mojom_bindings_generator.gypi',
       ],
       'sources': [
         'common/stash.mojom',
       ],
     },
     {
       # GN version: //extensions/common
+      'target_name': 'extensions_common_constants',
+      'type': 'static_library',
+      'include_dirs': [
+        '..',
+        '<(INTERMEDIATE_DIR)',
+      ],
+      'sources': [
+        # Note: sources list duplicated in GN build.
+        'common/constants.cc',
+        'common/constants.h',
+      ],
+      # Disable c4267 warnings until we fix size_t to int truncations.
+      'msvs_disabled_warnings': [ 4267, ],
+    },
+    {
+      # GN version: //extensions/common
       'target_name': 'extensions_common',
       'type': 'static_library',
       'dependencies': [
         '../components/components.gyp:crx_file',
         '../components/components.gyp:url_matcher',
         '../content/content.gyp:content_common',
         '../crypto/crypto.gyp:crypto',
         '../ipc/ipc.gyp:ipc',
         '../net/net.gyp:net',
         '../third_party/re2/re2.gyp:re2',
         '../ui/base/ui_base.gyp:ui_base',
         '../ui/gfx/gfx.gyp:gfx_geometry',
         '../ui/gfx/ipc/gfx_ipc.gyp:gfx_ipc',
         '../url/url.gyp:url_lib',
         '../third_party/libxml/libxml.gyp:libxml',
         'extensions_resources.gyp:extensions_resources',
         'extensions_strings.gyp:extensions_strings',
+        'extensions_common_constants',
         'extensions_common_mojo',
       ],
       'include_dirs': [
         '..',
         '<(INTERMEDIATE_DIR)',
       ],
       'sources': [
         # Note: sources list duplicated in GN build.
         'common/api/bluetooth/bluetooth_manifest_data.cc',
         'common/api/bluetooth/bluetooth_manifest_data.h',
         'common/api/bluetooth/bluetooth_manifest_handler.cc',
         'common/api/bluetooth/bluetooth_manifest_handler.h',
         'common/api/bluetooth/bluetooth_manifest_permission.cc',
         'common/api/bluetooth/bluetooth_manifest_permission.h',
         'common/api/messaging/message.h',
         'common/api/sockets/sockets_manifest_data.cc',
         'common/api/sockets/sockets_manifest_data.h',
         'common/api/sockets/sockets_manifest_handler.cc',
         'common/api/sockets/sockets_manifest_handler.h',
         'common/api/sockets/sockets_manifest_permission.cc',
         'common/api/sockets/sockets_manifest_permission.h',
         'common/common_manifest_handlers.cc',
         'common/common_manifest_handlers.h',
-        'common/constants.cc',
-        'common/constants.h',
         'common/csp_validator.cc',
         'common/csp_validator.h',
         'common/dom_action_types.h',
         'common/draggable_region.cc',
         'common/draggable_region.h',
         'common/error_utils.cc',
         'common/error_utils.h',
         'common/event_filter.cc',
         'common/event_filter.h',
         'common/event_filtering_info.cc',
@@ skipping 1118 matching lines @@
       'conditions': [
         ['OS=="win" and win_use_allocator_shim==1', {
           'dependencies': [
             '../base/allocator/allocator.gyp:allocator',
           ],
         }],
       ],
     },
   ]
 }