TextRun::length() should return an unsigned

TextRun::length() should return an unsigned.

Tightened int types to unsigned in TextRun to make it easier to reason about the code and in the process removed some casts and some ASSERTS that are no longer needed.

Also made the getter type consistent with the corresponding member type for for consistency where applicable.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183934

[lgombos, 2014-10-13 04:43:56]

l.gombos@samsung.com changed reviewers:
+ eae@chromium.org

[lgombos, 2014-10-13 04:43:57]

@eae, WDYT ? 

We can certainly move more into to unsigned, but I wanted to control the size of
this patch.

[mlamouri (slow - plz ping), 2014-10-13 09:07:23]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2014-10-13 09:07:24]

drive-by lgtm

[eae, 2014-10-17 23:20:02]

Seems resonable. LGTM

[lgombos, 2014-10-18 01:52:11]

The CQ bit was checked by l.gombos@samsung.com

[commit-bot: I haz the power, 2014-10-18 01:52:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/652483002/190001

[commit-bot: I haz the power, 2014-10-18 01:56:53]

Committed patchset #2 (id:190001) as 183934

[jochen (gone - plz use gerrit), 2014-10-20 10:42:56]

A revert of this CL (patchset #2 id:190001) has been created in
https://codereview.chromium.org/669633002/ by jochen@chromium.org.

The reason for reverting is: breaks
FindInPageControllerTest.FindInPageFormsTextAreas.

[jochen (gone - plz use gerrit), 2014-10-20 11:44:25]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2014-10-20 11:44:26]

https://codereview.chromium.org/652483002/diff/190001/Source/platform/fonts/F...
File Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/652483002/diff/190001/Source/platform/fonts/F...
Source/platform/fonts/Font.cpp:282: ASSERT(from >= 0);
this is hit in FindInPageControllerTest.FindInPageFormsTextAreas