Source/core/rendering/svg/SVGTextRunRenderingContext.cpp - Issue 652483002: TextRun::length() should return an unsigned

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

Issue 652483002: TextRun::length() should return an unsigned (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

diff --git a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

index 43c3296c6ec9713cff13e9affb9ba0c26436a475..fa5be51d5a0b2ba2dc789337f0e55903f03bda60 100644

--- a/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

+++ b/Source/core/rendering/svg/SVGTextRunRenderingContext.cpp

@@ -70,7 +70,7 @@ static inline RenderObject* renderObjectFromRun(const TextRun& run)

return 0;

}

-float SVGTextRunRenderingContext::floatWidthUsingSVGFont(const Font& font, const TextRun& run, int& charsConsumed, Glyph& glyphId) const

+float SVGTextRunRenderingContext::floatWidthUsingSVGFont(const Font& font, const TextRun& run, unsigned& charsConsumed, Glyph& glyphId) const

{

SimpleShaper it(&font, run);

GlyphBuffer glyphBuffer;